Re: [PATCH v2 4/4] kernel: add support for init_array constructors

2013-09-10 Thread Rusty Russell
Frantisek Hrbata writes: > On Tue, Sep 10, 2013 at 03:05:57PM +0930, Rusty Russell wrote: >> Frantisek Hrbata writes: >> > On Mon, Sep 09, 2013 at 10:44:03AM +0930, Rusty Russell wrote: >> >> Kyle McMartin writes: >> >> > On Fri, Sep 06, 2013 at 07:51:18PM +0200, Frantisek Hrbata wrote: >> >> >>

Re: [PATCH v2 4/4] kernel: add support for init_array constructors

2013-09-10 Thread Frantisek Hrbata
On Tue, Sep 10, 2013 at 03:05:57PM +0930, Rusty Russell wrote: > Frantisek Hrbata writes: > > On Mon, Sep 09, 2013 at 10:44:03AM +0930, Rusty Russell wrote: > >> Kyle McMartin writes: > >> > On Fri, Sep 06, 2013 at 07:51:18PM +0200, Frantisek Hrbata wrote: > >> >> > > v2: - reuse mod->ctors for .

Re: [PATCH v2 4/4] kernel: add support for init_array constructors

2013-09-10 Thread Rusty Russell
Frantisek Hrbata writes: > On Mon, Sep 09, 2013 at 10:44:03AM +0930, Rusty Russell wrote: >> Kyle McMartin writes: >> > On Fri, Sep 06, 2013 at 07:51:18PM +0200, Frantisek Hrbata wrote: >> >> > > v2: - reuse mod->ctors for .init_array section for modules, because >> >> > > gcc uses >> >> > >

Re: [PATCH v2 4/4] kernel: add support for init_array constructors

2013-09-09 Thread Kyle McMartin
On Mon, Sep 09, 2013 at 06:28:14PM +0200, Frantisek Hrbata wrote: > I'm not sure if coexistence of .ctors and .init_array sections should result > in > denial of module, but I for sure know nothing about this :). Could you maybe > privide one example of the "weird thing"? > They shouldn't exist

Re: [PATCH v2 4/4] kernel: add support for init_array constructors

2013-09-09 Thread Frantisek Hrbata
On Mon, Sep 09, 2013 at 10:44:03AM +0930, Rusty Russell wrote: > Kyle McMartin writes: > > On Fri, Sep 06, 2013 at 07:51:18PM +0200, Frantisek Hrbata wrote: > >> > > v2: - reuse mod->ctors for .init_array section for modules, because > >> > > gcc uses > >> > > .ctors or .init_array, but not

Re: [PATCH v2 4/4] kernel: add support for init_array constructors

2013-09-08 Thread Rusty Russell
Kyle McMartin writes: > On Fri, Sep 06, 2013 at 07:51:18PM +0200, Frantisek Hrbata wrote: >> > > v2: - reuse mod->ctors for .init_array section for modules, because gcc >> > > uses >> > > .ctors or .init_array, but not both at the same time >> > > >> > > Signed-off-by: Frantisek Hrbata >>

Re: [PATCH v2 4/4] kernel: add support for init_array constructors

2013-09-06 Thread Kyle McMartin
On Fri, Sep 06, 2013 at 07:51:18PM +0200, Frantisek Hrbata wrote: > > > v2: - reuse mod->ctors for .init_array section for modules, because gcc > > > uses > > > .ctors or .init_array, but not both at the same time > > > > > > Signed-off-by: Frantisek Hrbata > > > > Might be nice to documen

Re: [PATCH v2 4/4] kernel: add support for init_array constructors

2013-09-06 Thread Frantisek Hrbata
On Fri, Sep 06, 2013 at 11:43:08AM +0930, Rusty Russell wrote: > Frantisek Hrbata writes: > > This adds the .init_array section as yet another section with constructors. > > This > > is needed because gcc could add __gcov_init calls to .init_array or .ctors > > section, depending on gcc version.

Re: [PATCH v2 4/4] kernel: add support for init_array constructors

2013-09-05 Thread Rusty Russell
Frantisek Hrbata writes: > This adds the .init_array section as yet another section with constructors. > This > is needed because gcc could add __gcov_init calls to .init_array or .ctors > section, depending on gcc version. > > v2: - reuse mod->ctors for .init_array section for modules, because g

[PATCH v2 4/4] kernel: add support for init_array constructors

2013-09-04 Thread Frantisek Hrbata
This adds the .init_array section as yet another section with constructors. This is needed because gcc could add __gcov_init calls to .init_array or .ctors section, depending on gcc version. v2: - reuse mod->ctors for .init_array section for modules, because gcc uses .ctors or .init_array, b