Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block

2015-10-26 Thread Maxime Ripard
Hi, On Tue, Oct 06, 2015 at 12:38:57PM +0200, Code Kipper wrote: > >> >> +static void sun4i_spdif_configure(struct sun4i_spdif_dev *host) > >> >> +{ > >> >> + u32 reg_val; > >> >> + > >> >> + /* soft reset SPDIF */ > >> >> + regmap_write(host->regmap, SUN4I_SPDIF_CTL, > >> >> SUN4I_SP

Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block

2015-10-06 Thread Code Kipper
On 6 October 2015 at 11:00, Maxime Ripard wrote: > On Fri, Oct 02, 2015 at 08:44:03AM +0200, Code Kipper wrote: >> >> +config SND_SOC_SUNXI_DAI_SPDIF >> >> +tristate >> >> + depends on OF >> >> +select SND_SOC_GENERIC_DMAENGINE_PCM >> >> +select REGMAP_MMIO >> >> + >> >

Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block

2015-10-06 Thread Maxime Ripard
On Fri, Oct 02, 2015 at 08:44:03AM +0200, Code Kipper wrote: > >> +config SND_SOC_SUNXI_DAI_SPDIF > >> +tristate > >> + depends on OF > >> +select SND_SOC_GENERIC_DMAENGINE_PCM > >> +select REGMAP_MMIO > >> + > >> +config SND_SOC_SUNXI_MACHINE_SPDIF > >> +tristat

Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block

2015-10-01 Thread Code Kipper
>> +config SND_SOC_SUNXI_DAI_SPDIF >> +tristate >> + depends on OF >> +select SND_SOC_GENERIC_DMAENGINE_PCM >> +select REGMAP_MMIO >> + >> +config SND_SOC_SUNXI_MACHINE_SPDIF >> +tristate "APB on-chip sun4i/sun5i/sun7i SPDIF" >> + depends on OF >> +se

Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block

2015-10-01 Thread Maxime Ripard
On Wed, Sep 30, 2015 at 07:50:58PM +0200, codekip...@gmail.com wrote: > From: Marcus Cooper > > The sun4i, sun6i and sun7i SoC families have an SPDIF > block which is capable of playback and capture. > > This patch enables the playback of this block for > the sun4i and sun7i families. > > Signe

Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block

2015-09-30 Thread kbuild test robot
Hi Marcus, [auto build test results on next-20150930 -- if it's inappropriate base, please ignore] reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> sound/soc/sunxi/sun4i-spdif.c:207:6: sparse:

Re: [PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block

2015-09-30 Thread kbuild test robot
Hi Marcus, [auto build test results on next-20150930 -- if it's inappropriate base, please ignore] coccinelle warnings: (new ones prefixed by >>) >> sound/soc/sunxi/sun4i-spdif.c:599:3-8: No need to set .owner here. The core >> will do it. Please review and possibly fold the followup patch.

[PATCH v2 4/4] ASOC: sunxi: Add support for the spdif block

2015-09-30 Thread codekipper
From: Marcus Cooper The sun4i, sun6i and sun7i SoC families have an SPDIF block which is capable of playback and capture. This patch enables the playback of this block for the sun4i and sun7i families. Signed-off-by: Marcus Cooper --- sound/soc/sunxi/Kconfig | 12 + sound/soc/sunxi/Mak