Re: [PATCH v2 3/6] spi: sh-msiof: Add support for R-Car H2 and M2

2014-02-28 Thread Geert Uytterhoeven
Hi Laurent, On Fri, Feb 28, 2014 at 12:02 AM, Laurent Pinchart wrote: >> And if we remove "renesas,sh-msiof", we should probably remove >> "renesas,sh-mobile-msiof", too, as there are no current users, and it also >> assumes the same MSIOF implementation? > > I'm not too familiar with the MSIOF h

Re: [PATCH v2 3/6] spi: sh-msiof: Add support for R-Car H2 and M2

2014-02-27 Thread Laurent Pinchart
Hi Geert, On Thursday 27 February 2014 12:09:52 Geert Uytterhoeven wrote: > On Thu, Feb 27, 2014 at 11:41 AM, Laurent Pinchart wrote: > >> >> -- compatible : "renesas,sh-msiof" for SuperH, or > >> >> +- compatible : "renesas,msiof-" for SoCs, > >> >> + "ren

Re: [PATCH v2 3/6] spi: sh-msiof: Add support for R-Car H2 and M2

2014-02-27 Thread Geert Uytterhoeven
On Thu, Feb 27, 2014 at 11:41 AM, Laurent Pinchart wrote: >> >> -- compatible : "renesas,sh-msiof" for SuperH, or >> >> +- compatible : "renesas,msiof-" for SoCs, >> >> + "renesas,sh-msiof" for SuperH, or >> >>"renesas,sh-mobile-msio

Re: [PATCH v2 3/6] spi: sh-msiof: Add support for R-Car H2 and M2

2014-02-27 Thread Laurent Pinchart
Hi Geert, On Thursday 27 February 2014 09:39:54 Geert Uytterhoeven wrote: > On Wed, Feb 26, 2014 at 11:16 PM, Laurent Pinchart wrote: > >> diff --git a/Documentation/devicetree/bindings/spi/sh-msiof.txt > >> b/Documentation/devicetree/bindings/spi/sh-msiof.txt index > >> eae3c8c9300e..1f0cb33763a1

Re: [PATCH v2 3/6] spi: sh-msiof: Add support for R-Car H2 and M2

2014-02-27 Thread Geert Uytterhoeven
On Wed, Feb 26, 2014 at 11:16 PM, Laurent Pinchart wrote: >> diff --git a/Documentation/devicetree/bindings/spi/sh-msiof.txt >> b/Documentation/devicetree/bindings/spi/sh-msiof.txt index >> eae3c8c9300e..1f0cb33763a1 100644 >> --- a/Documentation/devicetree/bindings/spi/sh-msiof.txt >> +++ b/Docum

Re: [PATCH v2 3/6] spi: sh-msiof: Add support for R-Car H2 and M2

2014-02-26 Thread Geert Uytterhoeven
Hi Laurent, On Wed, Feb 26, 2014 at 11:16 PM, Laurent Pinchart wrote: >> diff --git a/Documentation/devicetree/bindings/spi/sh-msiof.txt >> b/Documentation/devicetree/bindings/spi/sh-msiof.txt index >> eae3c8c9300e..1f0cb33763a1 100644 >> --- a/Documentation/devicetree/bindings/spi/sh-msiof.txt >

Re: [PATCH v2 3/6] spi: sh-msiof: Add support for R-Car H2 and M2

2014-02-26 Thread Laurent Pinchart
Hi Geert, Thank you for the patch. Overall the series is great. I ran some time ago into issues with CCF due to the driver use of spi-bitbang, I'm happy to see this being fixed, thanks a lot. I have one small comment below though. On Tuesday 25 February 2014 11:21:10 Geert Uytterhoeven wrote:

[PATCH v2 3/6] spi: sh-msiof: Add support for R-Car H2 and M2

2014-02-25 Thread Geert Uytterhoeven
From: Geert Uytterhoeven Add support for the MSIOF variant in the R-Car H2 (r8a7790) and M2 (r8a7791) SoCs. Binding documentation: - Add future-proof "renesas,msiof-" compatible values, - The default for "renesas,rx-fifo-size" is 256 on R-Car H2 and M2, - "renesas,tx-fifo-size" and "renesa