Re: [PATCH v2 3/6] elf: Fix failure handling in _dl_map_object_from_fd

2020-12-11 Thread Szabolcs Nagy
The 12/10/2020 15:25, Adhemerval Zanella wrote: > On 27/11/2020 10:20, Szabolcs Nagy via Libc-alpha wrote: > > There are many failure paths that call lose to do local cleanups > > in _dl_map_object_from_fd, but it did not clean everything. > > > > Handle l_phdr, l_libname and mapped segments in th

Re: [PATCH v2 3/6] elf: Fix failure handling in _dl_map_object_from_fd

2020-12-10 Thread Adhemerval Zanella
On 27/11/2020 10:20, Szabolcs Nagy via Libc-alpha wrote: > There are many failure paths that call lose to do local cleanups > in _dl_map_object_from_fd, but it did not clean everything. > > Handle l_phdr, l_libname and mapped segments in the common failure > handling code. > > There are variou

[PATCH v2 3/6] elf: Fix failure handling in _dl_map_object_from_fd

2020-11-27 Thread Szabolcs Nagy
There are many failure paths that call lose to do local cleanups in _dl_map_object_from_fd, but it did not clean everything. Handle l_phdr, l_libname and mapped segments in the common failure handling code. There are various bits that may not be cleaned properly on failure (e.g. executable stack,