Re: [PATCH v2 3/4] x86/efi: print size and base in binary units in efi_print_memmap

2016-01-22 Thread Andrew Morton
On Fri, 22 Jan 2016 15:11:00 + Matt Fleming wrote: > > >> + md->phys_addr, md->phys_addr + size - 1, > > > > > > So I did s/ - 1// here, but worried. > > > > I'm pretty sure the series should go via efi tree. > > Right, because of the prerequisite patches sat in my tree

Re: [PATCH v2 3/4] x86/efi: print size and base in binary units in efi_print_memmap

2016-01-22 Thread Matt Fleming
On Fri, 22 Jan, at 09:08:00AM, Andy Shevchenko wrote: > On Fri, Jan 22, 2016 at 12:35 AM, Andrew Morton > wrote: > > On Thu, 21 Jan 2016 17:22:31 +0200 Andy Shevchenko > > wrote: > > > >> From: Robert Elliott > >> > >> Print the base in the best-fit B, KiB, MiB, etc. units rather than > >> alwa

Re: [PATCH v2 3/4] x86/efi: print size and base in binary units in efi_print_memmap

2016-01-21 Thread Andy Shevchenko
On Fri, Jan 22, 2016 at 12:35 AM, Andrew Morton wrote: > On Thu, 21 Jan 2016 17:22:31 +0200 Andy Shevchenko > wrote: > >> From: Robert Elliott >> >> Print the base in the best-fit B, KiB, MiB, etc. units rather than >> always MiB. This avoids rounding, which can be misleading. >> >> Use proper

Re: [PATCH v2 3/4] x86/efi: print size and base in binary units in efi_print_memmap

2016-01-21 Thread Andrew Morton
On Thu, 21 Jan 2016 17:22:31 +0200 Andy Shevchenko wrote: > From: Robert Elliott > > Print the base in the best-fit B, KiB, MiB, etc. units rather than > always MiB. This avoids rounding, which can be misleading. > > Use proper IEC binary units (KiB, MiB, etc.) rather than misuse SI > decimal

[PATCH v2 3/4] x86/efi: print size and base in binary units in efi_print_memmap

2016-01-21 Thread Andy Shevchenko
From: Robert Elliott Print the base in the best-fit B, KiB, MiB, etc. units rather than always MiB. This avoids rounding, which can be misleading. Use proper IEC binary units (KiB, MiB, etc.) rather than misuse SI decimal units (KB, MB, etc.). old: efi: mem61: [Persistent Memory | | |