Re: [PATCH v2 3/4] PCI: rcar: Add runtime PM support to pcie-rcar

2016-01-06 Thread Wolfram Sang
On Wed, Jan 06, 2016 at 09:45:46AM +0100, Geert Uytterhoeven wrote: > Hi Wolfram, > > On Wed, Jan 6, 2016 at 9:35 AM, Wolfram Sang wrote: > >> +err_pm_put: > >> + pm_runtime_put(pcie->dev); > >> + > >> +err_pm_disable: > >> + pm_runtime_disable(pcie->dev); > > > > What about put/disable i

Re: [PATCH v2 3/4] PCI: rcar: Add runtime PM support to pcie-rcar

2016-01-06 Thread Geert Uytterhoeven
Hi Wolfram, On Wed, Jan 6, 2016 at 9:35 AM, Wolfram Sang wrote: >> +err_pm_put: >> + pm_runtime_put(pcie->dev); >> + >> +err_pm_disable: >> + pm_runtime_disable(pcie->dev); > > What about put/disable in the remove part? Which remove part? (been there, done that ;-) Gr{oetje,eeting}s,

Re: [PATCH v2 3/4] PCI: rcar: Add runtime PM support to pcie-rcar

2016-01-06 Thread Wolfram Sang
> +err_pm_put: > + pm_runtime_put(pcie->dev); > + > +err_pm_disable: > + pm_runtime_disable(pcie->dev); What about put/disable in the remove part? signature.asc Description: Digital signature

[PATCH v2 3/4] PCI: rcar: Add runtime PM support to pcie-rcar

2016-01-05 Thread Phil Edworthy
If runtime PM is enabled in the kernel config, simply enable the clocks once during probe. Signed-off-by: Phil Edworthy --- v2: - No changes. --- drivers/pci/host/pcie-rcar.c | 44 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/dr