Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd

2016-06-20 Thread Kevin Hilman
Sudeep Holla writes: > This patch hooks up the support for device power domain provided by > SCPI using the Linux generic power domain infrastructure. > > Cc: "Rafael J. Wysocki" > Cc: Kevin Hilman > Cc: Ulf Hansson > Cc: linux...@vger.kernel.org > Signed-off-by: Sudeep Holla [...] > +stati

Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd

2016-06-20 Thread Sudeep Holla
On 20/06/16 18:53, Kevin Hilman wrote: Sudeep Holla writes: This patch hooks up the support for device power domain provided by SCPI using the Linux generic power domain infrastructure. Cc: "Rafael J. Wysocki" Cc: Kevin Hilman Cc: Ulf Hansson Cc: linux...@vger.kernel.org Signed-off-by: S

Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd

2016-06-20 Thread Kevin Hilman
"Jon Medhurst (Tixy)" writes: > On Thu, 2016-06-16 at 18:59 +0100, Sudeep Holla wrote: >> >> On 16/06/16 18:47, Jon Medhurst (Tixy) wrote: >> > On Thu, 2016-06-16 at 11:38 +0100, Sudeep Holla wrote: >> > [...] >> >> +enum scpi_power_domain_state { >> >> + SCPI_PD_STATE_ON = 0, >> >> + SCPI_PD_ST

Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd

2016-06-20 Thread Sudeep Holla
On 20/06/16 18:50, Kevin Hilman wrote: "Jon Medhurst (Tixy)" writes: On Thu, 2016-06-16 at 18:59 +0100, Sudeep Holla wrote: On 16/06/16 18:47, Jon Medhurst (Tixy) wrote: On Thu, 2016-06-16 at 11:38 +0100, Sudeep Holla wrote: [...] +enum scpi_power_domain_state { + SCPI_PD_STATE_ON

Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd

2016-06-17 Thread Sudeep Holla
On 17/06/16 09:55, Sudeep Holla wrote: Hi Ulf, On 16/06/16 11:38, Sudeep Holla wrote: This patch hooks up the support for device power domain provided by SCPI using the Linux generic power domain infrastructure. Cc: "Rafael J. Wysocki" Cc: Kevin Hilman Cc: Ulf Hansson Can you review thi

Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd

2016-06-17 Thread Sudeep Holla
Hi Ulf, On 16/06/16 11:38, Sudeep Holla wrote: This patch hooks up the support for device power domain provided by SCPI using the Linux generic power domain infrastructure. Cc: "Rafael J. Wysocki" Cc: Kevin Hilman Cc: Ulf Hansson Can you review this ? I have cc-ed you on the entire series.

Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd

2016-06-17 Thread Sudeep Holla
On 17/06/16 09:19, Jon Medhurst (Tixy) wrote: On Thu, 2016-06-16 at 18:59 +0100, Sudeep Holla wrote: On 16/06/16 18:47, Jon Medhurst (Tixy) wrote: On Thu, 2016-06-16 at 11:38 +0100, Sudeep Holla wrote: [...] +enum scpi_power_domain_state { + SCPI_PD_STATE_ON = 0, + SCPI_PD_STATE

Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd

2016-06-17 Thread Jon Medhurst (Tixy)
On Thu, 2016-06-16 at 18:59 +0100, Sudeep Holla wrote: > > On 16/06/16 18:47, Jon Medhurst (Tixy) wrote: > > On Thu, 2016-06-16 at 11:38 +0100, Sudeep Holla wrote: > > [...] > >> +enum scpi_power_domain_state { > >> + SCPI_PD_STATE_ON = 0, > >> + SCPI_PD_STATE_OFF = 3, > >> +}; > > > > The SCPI

Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd

2016-06-16 Thread Sudeep Holla
On 16/06/16 18:47, Jon Medhurst (Tixy) wrote: On Thu, 2016-06-16 at 11:38 +0100, Sudeep Holla wrote: [...] +enum scpi_power_domain_state { + SCPI_PD_STATE_ON = 0, + SCPI_PD_STATE_OFF = 3, +}; The SCPI doc defines the meaning of these numbers (0 and 3) in the 'Juno specifics' chap

Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd

2016-06-16 Thread Jon Medhurst (Tixy)
On Thu, 2016-06-16 at 11:38 +0100, Sudeep Holla wrote: [...] > +enum scpi_power_domain_state { > + SCPI_PD_STATE_ON = 0, > + SCPI_PD_STATE_OFF = 3, > +}; The SCPI doc defines the meaning of these numbers (0 and 3) in the 'Juno specifics' chapter. So does these values need to come from devi

[PATCH v2 3/3] firmware: scpi: add device power domain support using genpd

2016-06-16 Thread Sudeep Holla
This patch hooks up the support for device power domain provided by SCPI using the Linux generic power domain infrastructure. Cc: "Rafael J. Wysocki" Cc: Kevin Hilman Cc: Ulf Hansson Cc: linux...@vger.kernel.org Signed-off-by: Sudeep Holla --- drivers/firmware/Kconfig | 9 +++ driv