Re: [PATCH v2 28/62] objtool: Fix weak symbol hole detection for .cold functions

2025-05-26 Thread Peter Zijlstra
On Fri, May 09, 2025 at 01:16:52PM -0700, Josh Poimboeuf wrote: > When ignore_unreachable_insn() looks for weak function holes which jump > to their .cold functions, it assumes the parent function comes before > the corresponding .cold function in the symbol table. That's not > necessarily the cas

[PATCH v2 28/62] objtool: Fix weak symbol hole detection for .cold functions

2025-05-09 Thread Josh Poimboeuf
When ignore_unreachable_insn() looks for weak function holes which jump to their .cold functions, it assumes the parent function comes before the corresponding .cold function in the symbol table. That's not necessarily the case with -ffunction-sections. Mark all the holes beforehand (including .c