Re: [PATCH v2 23/31] mbcache: make mbcache naming more generic

2017-06-21 Thread Tahsin Erdogan
Hi Andreas, I have incorporated your suggestions into another patch that renames things in ext2/ext4 ("[PATCH 24/32] ext2, ext4: make mb block cache names more explicit"). > Since we now also have the ea_inode cache, it would be better to rename > s_mb_cache to s_mb_block_cache to make it more cle

Re: [PATCH v2 23/31] mbcache: make mbcache naming more generic

2017-06-21 Thread Andreas Dilger
On Jun 20, 2017, at 3:01 AM, Tahsin Erdogan wrote: > > Make names more generic so that mbcache usage is not limited to > block sharing. In a subsequent patch in the series > ("ext4: xattr inode deduplication"), we start using the mbcache code > for sharing xattr inodes. With that patch, old mb_ca

Re: [PATCH v2 23/31] mbcache: make mbcache naming more generic

2017-06-21 Thread Andreas Dilger
On Jun 20, 2017, at 3:01 AM, Tahsin Erdogan wrote: > > Make names more generic so that mbcache usage is not limited to > block sharing. In a subsequent patch in the series > ("ext4: xattr inode deduplication"), we start using the mbcache code > for sharing xattr inodes. With that patch, old mb_ca

[PATCH v2 23/31] mbcache: make mbcache naming more generic

2017-06-20 Thread Tahsin Erdogan
Make names more generic so that mbcache usage is not limited to block sharing. In a subsequent patch in the series ("ext4: xattr inode deduplication"), we start using the mbcache code for sharing xattr inodes. With that patch, old mb_cache_entry.e_block field could be holding either a block number