Re: [PATCH v2 2/9] x86: objtool: use asm macro for better compiler decisions

2018-06-04 Thread kbuild test robot
Hi Nadav, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17 next-20180604] [cannot apply to tip/x86/core] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://

Re: [PATCH v2 2/9] x86: objtool: use asm macro for better compiler decisions

2018-06-04 Thread Josh Poimboeuf
On Mon, Jun 04, 2018 at 04:21:24AM -0700, Nadav Amit wrote: > +#ifdef CONFIG_STACK_VALIDATION > +.macro ANNOTATE_UNREACHABLE counter:req > +\counter: > + .pushsection .discard.unreachable > + .long \counter\()b -. > + .popsection > +.endm > + > +.macro ANNOTATE_REACHABLE counter:req > +

[PATCH v2 2/9] x86: objtool: use asm macro for better compiler decisions

2018-06-04 Thread Nadav Amit
GCC considers the number of statements in inlined assembly blocks, according to new-lines and semicolons, as an indication to the cost of the block in time and space. This data is distorted by the kernel code, which puts information in alternative sections. As a result, the compiler may perform inc