RE: [PATCH v2 2/9] scsi: ufshpb: Add host control mode support to rsp_upiu

2021-02-02 Thread Avri Altman
> On Tue, Feb 02, 2021 at 11:24:04AM +, Avri Altman wrote: > > > > > > > > On Tue, Feb 02, 2021 at 10:30:00AM +0200, Avri Altman wrote: > > > > diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h > > > > index afeb6365daf8..5ec4023db74d 100644 > > > > --- a/drivers/scsi/ufs/ufshp

Re: [PATCH v2 2/9] scsi: ufshpb: Add host control mode support to rsp_upiu

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 11:24:04AM +, Avri Altman wrote: > > > > > On Tue, Feb 02, 2021 at 10:30:00AM +0200, Avri Altman wrote: > > > diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h > > > index afeb6365daf8..5ec4023db74d 100644 > > > --- a/drivers/scsi/ufs/ufshpb.h > > > +

RE: [PATCH v2 2/9] scsi: ufshpb: Add host control mode support to rsp_upiu

2021-02-02 Thread Avri Altman
> > On Tue, Feb 02, 2021 at 10:30:00AM +0200, Avri Altman wrote: > > diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h > > index afeb6365daf8..5ec4023db74d 100644 > > --- a/drivers/scsi/ufs/ufshpb.h > > +++ b/drivers/scsi/ufs/ufshpb.h > > @@ -48,6 +48,11 @@ enum UFSHPB_MODE { >

Re: [PATCH v2 2/9] scsi: ufshpb: Add host control mode support to rsp_upiu

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 10:30:00AM +0200, Avri Altman wrote: > diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h > index afeb6365daf8..5ec4023db74d 100644 > --- a/drivers/scsi/ufs/ufshpb.h > +++ b/drivers/scsi/ufs/ufshpb.h > @@ -48,6 +48,11 @@ enum UFSHPB_MODE { > HPB_DEVICE_

[PATCH v2 2/9] scsi: ufshpb: Add host control mode support to rsp_upiu

2021-02-02 Thread Avri Altman
In device control mode, the device may recommend the host to either activate or inactivate a region, and the host should follow. Meaning those are not actually recommendations, but more of instructions. On the contrary, in host control mode, the recommendation protocol is slightly changed: a) The