Re: [PATCH v2 2/9] gen_compile_commands: use choices for --log_levels option

2020-08-21 Thread Nick Desaulniers
On Fri, Aug 21, 2020 at 12:02 PM Masahiro Yamada wrote: > > Use 'choices' instead of the own code to check if the given parameter > is valid. > > I also simplified the help message because, with 'choices', --help > shows the list of valid parameters: > > --log_level {DEBUG,INFO,WARNING,ERROR,CRI

[PATCH v2 2/9] gen_compile_commands: use choices for --log_levels option

2020-08-21 Thread Masahiro Yamada
Use 'choices' instead of the own code to check if the given parameter is valid. I also simplified the help message because, with 'choices', --help shows the list of valid parameters: --log_level {DEBUG,INFO,WARNING,ERROR,CRITICAL} Signed-off-by: Masahiro Yamada --- Changes in v2: - New pat