Re: [PATCH v2 2/7] x86/entry/32: Simplify common_exception

2019-07-10 Thread Peter Zijlstra
On Wed, Jul 10, 2019 at 04:11:37PM -0400, Steven Rostedt wrote: > On Thu, 04 Jul 2019 21:55:57 +0200 > Peter Zijlstra wrote: > > - cld > > The only code change of this is that cld moved from the end to the > beginning. As this appears to match other SAVE_ALL users with respect > to ENCODE_FRAM

Re: [PATCH v2 2/7] x86/entry/32: Simplify common_exception

2019-07-10 Thread Steven Rostedt
On Thu, 04 Jul 2019 21:55:57 +0200 Peter Zijlstra wrote: > --- a/arch/x86/entry/entry_32.S > +++ b/arch/x86/entry/entry_32.S > @@ -294,9 +294,11 @@ > .Lfinished_frame_\@: > .endm > > -.macro SAVE_ALL pt_regs_ax=%eax switch_stacks=0 > +.macro SAVE_ALL pt_regs_ax=%eax switch_stacks=0 skip_gs=0

Re: [PATCH v2 2/7] x86/entry/32: Simplify common_exception

2019-07-04 Thread Andy Lutomirski
On Thu, Jul 4, 2019 at 1:03 PM Peter Zijlstra wrote: > > By adding one more option to SAVE_ALL we can make use of it in > common_exception and simplify things. This saves duplication later > where page_fault will no longer use common_exception. > Reviewed-by: Andy Lutomirski Although I'm still

[PATCH v2 2/7] x86/entry/32: Simplify common_exception

2019-07-04 Thread Peter Zijlstra
By adding one more option to SAVE_ALL we can make use of it in common_exception and simplify things. This saves duplication later where page_fault will no longer use common_exception. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/entry/entry_32.S | 36 +---