Re: [PATCH v2 2/5] pid: add pidfd_open()

2019-03-30 Thread Jonathan Kowalski
On Sat, Mar 30, 2019 at 2:37 PM Christian Brauner wrote: > > On Sat, Mar 30, 2019 at 12:53:57PM +0100, Jürg Billeter wrote: > > On Fri, 2019-03-29 at 16:54 +0100, Christian Brauner wrote: > > > diff --git a/include/uapi/linux/wait.h b/include/uapi/linux/wait.h > > > index ac49a220cf2a..d6c7c070199

Re: [PATCH v2 2/5] pid: add pidfd_open()

2019-03-30 Thread Christian Brauner
On Sat, Mar 30, 2019 at 12:53:57PM +0100, Jürg Billeter wrote: > On Fri, 2019-03-29 at 16:54 +0100, Christian Brauner wrote: > > diff --git a/include/uapi/linux/wait.h b/include/uapi/linux/wait.h > > index ac49a220cf2a..d6c7c0701997 100644 > > --- a/include/uapi/linux/wait.h > > +++ b/include/uapi/

Re: [PATCH v2 2/5] pid: add pidfd_open()

2019-03-30 Thread Jürg Billeter
On Fri, 2019-03-29 at 16:54 +0100, Christian Brauner wrote: > diff --git a/include/uapi/linux/wait.h b/include/uapi/linux/wait.h > index ac49a220cf2a..d6c7c0701997 100644 > --- a/include/uapi/linux/wait.h > +++ b/include/uapi/linux/wait.h > @@ -18,5 +18,7 @@ > #define P_PID1 > #de

Re: [PATCH v2 2/5] pid: add pidfd_open()

2019-03-29 Thread Christian Brauner
On Sat, Mar 30, 2019 at 12:45:46AM +0100, Jann Horn wrote: > On Fri, Mar 29, 2019 at 4:54 PM Christian Brauner > wrote: > > /* Introduction */ > > This adds the pidfd_open() syscall. > > pidfd_open() allows to retrieve file descriptors for a given pid. This > > includes both file descriptors for

Re: [PATCH v2 2/5] pid: add pidfd_open()

2019-03-29 Thread Jann Horn
On Fri, Mar 29, 2019 at 4:54 PM Christian Brauner wrote: > /* Introduction */ > This adds the pidfd_open() syscall. > pidfd_open() allows to retrieve file descriptors for a given pid. This > includes both file descriptors for processes and file descriptors for > threads. Looks good to me, overall

[PATCH v2 2/5] pid: add pidfd_open()

2019-03-29 Thread Christian Brauner
/* Introduction */ This adds the pidfd_open() syscall. pidfd_open() allows to retrieve file descriptors for a given pid. This includes both file descriptors for processes and file descriptors for threads. With the addition of this syscalls pidfd become independent of procfs just as pids are. Of co