Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-11-01 Thread Richard Fitzgerald
On 01/11/18 10:28, Charles Keepax wrote: On Mon, Oct 29, 2018 at 11:04:39AM +, Lee Jones wrote: On Fri, 26 Oct 2018, Mark Brown wrote: On Fri, Oct 26, 2018 at 09:00:51AM +0100, Lee Jones wrote: On Thu, 25 Oct 2018, Richard Fitzgerald wrote: Precisely my point. Lochnagar is a small

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-11-01 Thread Mark Brown
On Thu, Nov 01, 2018 at 11:40:01AM +, Richard Fitzgerald wrote: > On 01/11/18 10:28, Charles Keepax wrote: > > So pulling this out from earlier discussions in this thread, > > it seems I can happily move all the child device registration > > into device tree. I will also try this for the next

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-11-01 Thread Mark Brown
On Thu, Nov 01, 2018 at 10:28:28AM +, Charles Keepax wrote: > 1.2) Read all the registers from the device on boot > + Uses less memory > - Potentially very slow boot time > 1.3) Only read values as you touch registers > + Uses less memory > + U

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-11-01 Thread Richard Fitzgerald
On 01/11/18 10:28, Charles Keepax wrote: On Mon, Oct 29, 2018 at 11:04:39AM +, Lee Jones wrote: On Fri, 26 Oct 2018, Mark Brown wrote: On Fri, Oct 26, 2018 at 09:00:51AM +0100, Lee Jones wrote: On Thu, 25 Oct 2018, Richard Fitzgerald wrote: I have re-ordered some of the quotes here for t

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-11-01 Thread Charles Keepax
On Mon, Oct 29, 2018 at 11:04:39AM +, Lee Jones wrote: > On Fri, 26 Oct 2018, Mark Brown wrote: > > On Fri, Oct 26, 2018 at 09:00:51AM +0100, Lee Jones wrote: > > > On Thu, 25 Oct 2018, Richard Fitzgerald wrote: I have re-ordered some of the quotes here for the benefit of clarity. I will start

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-29 Thread Mark Brown
On Mon, Oct 29, 2018 at 11:04:39AM +, Lee Jones wrote: > On Fri, 26 Oct 2018, Mark Brown wrote: > > There's no *requirement* to provide the data even if you're using the > > cache (and the cache support is entirely optional), there's just costs > > to not providing it in terms of what features

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-29 Thread Richard Fitzgerald
On 29/10/18 11:04, Lee Jones wrote: On Fri, 26 Oct 2018, Mark Brown wrote: On Fri, Oct 26, 2018 at 09:00:51AM +0100, Lee Jones wrote: On Thu, 25 Oct 2018, Richard Fitzgerald wrote: Largely the point. How long do you think it would take to populate the cache if you had to read thousands of re

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-29 Thread Richard Fitzgerald
On 29/10/18 11:04, Lee Jones wrote: On Fri, 26 Oct 2018, Mark Brown wrote: On Fri, Oct 26, 2018 at 09:00:51AM +0100, Lee Jones wrote: On Thu, 25 Oct 2018, Richard Fitzgerald wrote: Largely the point. How long do you think it would take to populate the cache if you had to read thousands of re

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-29 Thread Lee Jones
On Fri, 26 Oct 2018, Mark Brown wrote: > On Fri, Oct 26, 2018 at 09:00:51AM +0100, Lee Jones wrote: > > On Thu, 25 Oct 2018, Richard Fitzgerald wrote: > > > > Largely the point. How long do you think it would take to populate the > > > cache if you had to read thousands of registers over I2C? Boot

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-26 Thread Mark Brown
On Fri, Oct 26, 2018 at 09:00:51AM +0100, Lee Jones wrote: > On Thu, 25 Oct 2018, Richard Fitzgerald wrote: > > Largely the point. How long do you think it would take to populate the > > cache if you had to read thousands of registers over I2C? Boot time matters. > > Deferring it until it's touche

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-26 Thread Mark Brown
On Thu, Oct 25, 2018 at 02:47:59PM +0100, Richard Fitzgerald wrote: > access. What does regmap debugfs do if you don't have a readables > list? Just reading a debugfs shouldn't be able to kill the hardware. > You might need to add a precious list which is more error prone > than listing the valid

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-26 Thread Mark Brown
On Thu, Oct 25, 2018 at 01:49:05PM +0100, Charles Keepax wrote: > I don't think you can sensibly get away with not supplying > default values. You say most sane register layouts have zero > values, alas again you may not be the biggest fan of our hardware > guys. The Lochnagar actually does have m

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-26 Thread Lee Jones
On Thu, 25 Oct 2018, Richard Fitzgerald wrote: > On 25/10/18 12:42, Lee Jones wrote: > > On Thu, 25 Oct 2018, Richard Fitzgerald wrote: > > > On 25/10/18 09:26, Charles Keepax wrote: > > > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: > > > > > On Mon, 08 Oct 2018, Charles Keepax wr

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-26 Thread Lee Jones
On Thu, 25 Oct 2018, Charles Keepax wrote: > On Thu, Oct 25, 2018 at 12:42:05PM +0100, Lee Jones wrote: > > On Thu, 25 Oct 2018, Richard Fitzgerald wrote: > > > On 25/10/18 09:26, Charles Keepax wrote: > > > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: > > > > > On Mon, 08 Oct 2018

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Richard Fitzgerald
On 25/10/18 14:20, Charles Keepax wrote: On Thu, Oct 25, 2018 at 01:49:05PM +0100, Charles Keepax wrote: On Thu, Oct 25, 2018 at 12:42:05PM +0100, Lee Jones wrote: On Thu, 25 Oct 2018, Richard Fitzgerald wrote: On 25/10/18 09:26, Charles Keepax wrote: On Thu, Oct 25, 2018 at 08:44:59AM +0100,

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Richard Fitzgerald
On 25/10/18 12:42, Lee Jones wrote: On Thu, 25 Oct 2018, Richard Fitzgerald wrote: On 25/10/18 09:26, Charles Keepax wrote: On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: On Mon, 08 Oct 2018, Charles Keepax wrote: From: Charles Keepax +static const struct reg_default lochnagar1_r

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Charles Keepax
On Thu, Oct 25, 2018 at 01:49:05PM +0100, Charles Keepax wrote: > On Thu, Oct 25, 2018 at 12:42:05PM +0100, Lee Jones wrote: > > On Thu, 25 Oct 2018, Richard Fitzgerald wrote: > > > On 25/10/18 09:26, Charles Keepax wrote: > > > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: > > > > >

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Charles Keepax
On Thu, Oct 25, 2018 at 12:42:05PM +0100, Lee Jones wrote: > On Thu, 25 Oct 2018, Richard Fitzgerald wrote: > > On 25/10/18 09:26, Charles Keepax wrote: > > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: > > > > On Mon, 08 Oct 2018, Charles Keepax wrote: > > > > > From: Charles Keepax

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Lee Jones
On Thu, 25 Oct 2018, Richard Fitzgerald wrote: > On 25/10/18 09:26, Charles Keepax wrote: > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: > > > On Mon, 08 Oct 2018, Charles Keepax wrote: > > > > From: Charles Keepax > > > > +static const struct reg_default lochnagar1_reg_defaults[]

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Charles Keepax
On Thu, Oct 25, 2018 at 11:12:48AM +0100, Mark Brown wrote: > On Thu, Oct 25, 2018 at 10:28:16AM +0100, Richard Fitzgerald wrote: > > On 25/10/18 09:26, Charles Keepax wrote: > > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: > > > I really feel this isn't the driver you are objecting

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Mark Brown
On Thu, Oct 25, 2018 at 10:28:16AM +0100, Richard Fitzgerald wrote: > On 25/10/18 09:26, Charles Keepax wrote: > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: > > > I'm really not a fan of these so call 'patches'. > > > Can't you set the registers up proper way? > > I will see if

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Richard Fitzgerald
On 25/10/18 09:26, Charles Keepax wrote: On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: On Mon, 08 Oct 2018, Charles Keepax wrote: From: Charles Keepax +static const struct reg_default lochnagar1_reg_defaults[] = { + { LOCHNAGAR1_CDC_AIF1_SEL,0x00 }, + { LOCHNAGAR1_

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Charles Keepax
On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: > On Mon, 08 Oct 2018, Charles Keepax wrote: > > From: Charles Keepax > > +static const struct reg_default lochnagar1_reg_defaults[] = { > > + { LOCHNAGAR1_CDC_AIF1_SEL,0x00 }, > > + { LOCHNAGAR1_CDC_AIF2_SEL,0x00 }, ... > > +

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Lee Jones
On Mon, 08 Oct 2018, Charles Keepax wrote: > From: Charles Keepax > > Lochnagar is an evaluation and development board for Cirrus > Logic Smart CODEC and Amp devices. It allows the connection of > most Cirrus Logic devices on mini-cards, as well as allowing > connection of various application pr

[PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-08 Thread Charles Keepax
From: Charles Keepax Lochnagar is an evaluation and development board for Cirrus Logic Smart CODEC and Amp devices. It allows the connection of most Cirrus Logic devices on mini-cards, as well as allowing connection of various application processor systems to provide a full evaluation platform. T