Re: [PATCH v2 2/4] tools lib traceevent: Add options to plugins

2014-06-04 Thread Namhyung Kim
Hi Jiri, 2014-06-04 (수), 13:42 +0200, Jiri Olsa: > On Tue, Jun 03, 2014 at 03:51:22PM +0900, Namhyung Kim wrote: > > On Mon, 02 Jun 2014 23:20:14 -0400, Steven Rostedt wrote: > > > +void traceevent_plugin_free_options_list(char **list) > > > +{ > > > + int i; > > > + > > > + if (!list) > > > +

Re: [PATCH v2 2/4] tools lib traceevent: Add options to plugins

2014-06-04 Thread Jiri Olsa
On Tue, Jun 03, 2014 at 03:51:22PM +0900, Namhyung Kim wrote: > On Mon, 02 Jun 2014 23:20:14 -0400, Steven Rostedt wrote: > > +void traceevent_plugin_free_options_list(char **list) > > +{ > > + int i; > > + > > + if (!list) > > + return; > > + > > + if (list == (char **)((unsigned l

Re: [PATCH v2 2/4] tools lib traceevent: Add options to plugins

2014-06-02 Thread Namhyung Kim
On Mon, 02 Jun 2014 23:20:14 -0400, Steven Rostedt wrote: > +void traceevent_plugin_free_options_list(char **list) > +{ > + int i; > + > + if (!list) > + return; > + > + if (list == (char **)((unsigned long)-1)) It also should be: if (list == INVALID_PLUGIN_LIST_OP

[PATCH v2 2/4] tools lib traceevent: Add options to plugins

2014-06-02 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" The traceevent plugins allows developers to have their events print out information that is more advanced than what can be achieved by the trace event format files. As these plugins are used on the userspace side of the tracing tools, it is only logical that the