Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-12-18 Thread Mark Fasheh
On Tue, Nov 24, 2015 at 08:29:41PM -0700, Gang He wrote: > Hi Mark and Junxiao, > > > >>> > > On Tue, Nov 03, 2015 at 04:20:27PM +0800, Junxiao Bi wrote: > >> Hi Gang, > >> > >> On 11/03/2015 03:54 PM, Gang He wrote: > >> > Hi Junxiao, > >> > > >> > Thank for your reviewing. > >> > Current des

Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-24 Thread Gang He
Hi Junxiao, >>> > Hi Gang, > > On 11/25/2015 11:29 AM, Gang He wrote: >> Hi Mark and Junxiao, >> >> > >>> On Tue, Nov 03, 2015 at 04:20:27PM +0800, Junxiao Bi wrote: Hi Gang, On 11/03/2015 03:54 PM, Gang He wrote: > Hi Junxiao, > > Thank for your reviewing.

Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-24 Thread Junxiao Bi
Hi Gang, On 11/25/2015 11:29 AM, Gang He wrote: > Hi Mark and Junxiao, > > >> On Tue, Nov 03, 2015 at 04:20:27PM +0800, Junxiao Bi wrote: >>> Hi Gang, >>> >>> On 11/03/2015 03:54 PM, Gang He wrote: Hi Junxiao, Thank for your reviewing. Current design, we use a sysfile as

Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-24 Thread Junxiao Bi
On 11/25/2015 05:46 AM, Mark Fasheh wrote: > On Tue, Nov 03, 2015 at 04:20:27PM +0800, Junxiao Bi wrote: >> Hi Gang, >> >> On 11/03/2015 03:54 PM, Gang He wrote: >>> Hi Junxiao, >>> >>> Thank for your reviewing. >>> Current design, we use a sysfile as a interface to check/fix a file (via >>> pass

Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-24 Thread Gang He
Hi Mark and Junxiao, >>> > On Tue, Nov 03, 2015 at 04:20:27PM +0800, Junxiao Bi wrote: >> Hi Gang, >> >> On 11/03/2015 03:54 PM, Gang He wrote: >> > Hi Junxiao, >> > >> > Thank for your reviewing. >> > Current design, we use a sysfile as a interface to check/fix a file (via > pass a ino numbe

Re: [Ocfs2-devel] [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-24 Thread Mark Fasheh
On Wed, Oct 28, 2015 at 02:25:59PM +0800, Gang He wrote: > Implement online file check sysfile interfaces, e.g. > how to create the related sysfile according to device name, > how to display/handle file check request from the sysfile. > > Signed-off-by: Gang He FYI, This looks generally fine to

Re: [Ocfs2-devel] [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-24 Thread Srinivas Eeda
On 11/24/2015 01:46 PM, Mark Fasheh wrote: On Tue, Nov 03, 2015 at 04:20:27PM +0800, Junxiao Bi wrote: Hi Gang, On 11/03/2015 03:54 PM, Gang He wrote: Hi Junxiao, Thank for your reviewing. Current design, we use a sysfile as a interface to check/fix a file (via pass a ino number). But, this

Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-24 Thread Mark Fasheh
On Tue, Nov 03, 2015 at 04:20:27PM +0800, Junxiao Bi wrote: > Hi Gang, > > On 11/03/2015 03:54 PM, Gang He wrote: > > Hi Junxiao, > > > > Thank for your reviewing. > > Current design, we use a sysfile as a interface to check/fix a file (via > > pass a ino number). > > But, this operation is manu

Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-03 Thread Gang He
Hi Junxiao, >>> > Hi Gang, > > On 11/03/2015 03:54 PM, Gang He wrote: >> Hi Junxiao, >> >> Thank for your reviewing. >> Current design, we use a sysfile as a interface to check/fix a file (via > pass a ino number). >> But, this operation is manually triggered by user, instead of automatically

Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-03 Thread Junxiao Bi
Hi Gang, On 11/03/2015 03:54 PM, Gang He wrote: > Hi Junxiao, > > Thank for your reviewing. > Current design, we use a sysfile as a interface to check/fix a file (via pass > a ino number). > But, this operation is manually triggered by user, instead of automatically > fix in the kernel. > Why?

Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-03 Thread Gang He
Hi Junxiao, Thank for your reviewing. Current design, we use a sysfile as a interface to check/fix a file (via pass a ino number). But, this operation is manually triggered by user, instead of automatically fix in the kernel. Why? 1) we should let users make this decision, since some users do n

Re: [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-11-02 Thread Junxiao Bi
Hi Gang, I didn't see a need to add a sysfs file for the check and repair. This leaves a hard problem for customer to decide. How they decide whether they should repair the bad inode since this may cause corruption even harder? I think the error should be fixed by this feature automaticlly if repa

[PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

2015-10-27 Thread Gang He
Implement online file check sysfile interfaces, e.g. how to create the related sysfile according to device name, how to display/handle file check request from the sysfile. Signed-off-by: Gang He --- fs/ocfs2/Makefile| 3 +- fs/ocfs2/filecheck.c | 566 +++