Re: [PATCH v2 2/4] mm/sparse: introduce alloc_usemap_and_memmap

2013-08-28 Thread Yinghai Lu
On Wed, Aug 28, 2013 at 7:51 PM, Wanpeng Li wrote: > Hi Yinghai, >>> looks like that is what is your first version did. >>> >>> I updated it a little bit. please check it. >>> >> >>removed more lines. > > Thanks for your great work! > > The fixed patch looks good to me. If this is the last fix and

Re: [PATCH v2 2/4] mm/sparse: introduce alloc_usemap_and_memmap

2013-08-28 Thread Yinghai Lu
On Wed, Aug 28, 2013 at 7:34 PM, Yinghai Lu wrote: > On Wed, Aug 28, 2013 at 7:18 PM, Yinghai Lu wrote: >> please change to function pointer to >> void (*alloc_func)(void *data, >> unsigned long pnum_begin, >> unsigned long pnum_e

Re: [PATCH v2 2/4] mm/sparse: introduce alloc_usemap_and_memmap

2013-08-28 Thread Yinghai Lu
On Wed, Aug 28, 2013 at 7:18 PM, Yinghai Lu wrote: > please change to function pointer to > void (*alloc_func)(void *data, > unsigned long pnum_begin, > unsigned long pnum_end, > unsigned long map_c

Re: [PATCH v2 2/4] mm/sparse: introduce alloc_usemap_and_memmap

2013-08-28 Thread Yinghai Lu
On Thu, Aug 22, 2013 at 5:14 AM, Wanpeng Li wrote: >From f21640b6dc15c76ac10fccada96e6b9fdce5a092 Mon Sep 17 00:00:00 2001 From: Wanpeng Li Date: Thu, 22 Aug 2013 19:57:54 +0800 Subject: [PATCH] mm/sparse: introduce alloc_usemap_and_memmap fix Pass function pointer to alloc_usemap_and_memmap() i

Re: [PATCH v2 2/4] mm/sparse: introduce alloc_usemap_and_memmap

2013-08-21 Thread Yinghai Lu
On Wed, Aug 21, 2013 at 12:29 AM, Wanpeng Li wrote: > Hi Yinghai, > On Tue, Aug 20, 2013 at 09:28:29PM -0700, Yinghai Lu wrote: >>On Tue, Aug 20, 2013 at 8:11 PM, Wanpeng Li wrote: >>> Hi Yinghai, >>> On Tue, Aug 20, 2013 at 05:02:17PM -0700, Yinghai Lu wrote: >> - /* ok, last chunk */ >>

Re: [PATCH v2 2/4] mm/sparse: introduce alloc_usemap_and_memmap

2013-08-20 Thread Yinghai Lu
On Tue, Aug 20, 2013 at 8:11 PM, Wanpeng Li wrote: > Hi Yinghai, > On Tue, Aug 20, 2013 at 05:02:17PM -0700, Yinghai Lu wrote: - /* ok, last chunk */ - sparse_early_usemaps_alloc_node(usemap_map, pnum_begin, NR_MEM_SECTIONS, - usema

Re: [PATCH v2 2/4] mm/sparse: introduce alloc_usemap_and_memmap

2013-08-20 Thread Yinghai Lu
On Tue, Aug 20, 2013 at 4:07 PM, Andrew Morton wrote: > On Tue, 20 Aug 2013 14:54:54 +0800 Wanpeng Li > wrote: > >> v1 -> v2: >> * add comments to describe alloc_usemap_and_memmap >> >> After commit 9bdac91424075("sparsemem: Put mem map for one node together."), >> vmemmap for one node will be

Re: [PATCH v2 2/4] mm/sparse: introduce alloc_usemap_and_memmap

2013-08-20 Thread Andrew Morton
On Tue, 20 Aug 2013 14:54:54 +0800 Wanpeng Li wrote: > v1 -> v2: > * add comments to describe alloc_usemap_and_memmap > > After commit 9bdac91424075("sparsemem: Put mem map for one node together."), > vmemmap for one node will be allocated together, its logic is similar as > memory allocation

[PATCH v2 2/4] mm/sparse: introduce alloc_usemap_and_memmap

2013-08-19 Thread Wanpeng Li
v1 -> v2: * add comments to describe alloc_usemap_and_memmap After commit 9bdac91424075("sparsemem: Put mem map for one node together."), vmemmap for one node will be allocated together, its logic is similar as memory allocation for pageblock flags. This patch introduce alloc_usemap_and_memmap