Re: [PATCH v2 2/4] mfd: cros_ec: add EC_PWM function definitions

2016-06-20 Thread Brian Norris
Hi Lee, On Mon, Jun 20, 2016 at 09:00:51AM +0100, Lee Jones wrote: > On Fri, 17 Jun 2016, Doug Anderson wrote: > > On Fri, Jun 17, 2016 at 1:06 AM, Lee Jones wrote: > > >> Probably the reason for all of these non-kernel-isms is that this > > >> isn't a kernel file. From the top of the file: > >

Re: [PATCH v2 2/4] mfd: cros_ec: add EC_PWM function definitions

2016-06-20 Thread Lee Jones
On Fri, 17 Jun 2016, Doug Anderson wrote: > Lee, > > On Fri, Jun 17, 2016 at 1:06 AM, Lee Jones wrote: > >> Probably the reason for all of these non-kernel-isms is that this > >> isn't a kernel file. From the top of the file: > >> > >> * NOTE: This file is copied verbatim from the ChromeOS EC

Re: [PATCH v2 2/4] mfd: cros_ec: add EC_PWM function definitions

2016-06-20 Thread Lee Jones
On Fri, 17 Jun 2016, Brian Norris wrote: > On Thu, Jun 16, 2016 at 04:38:17PM +0100, Lee Jones wrote: > > On Thu, 02 Jun 2016, Brian Norris wrote: > > > The EC_CMD_PWM_{GET,SET}_DUTY commands allow us to control a PWM that is > > > attached to the EC, rather than the main host SoC. The API provide

Re: [PATCH v2 2/4] mfd: cros_ec: add EC_PWM function definitions

2016-06-17 Thread Brian Norris
On Thu, Jun 16, 2016 at 04:38:17PM +0100, Lee Jones wrote: > On Thu, 02 Jun 2016, Brian Norris wrote: > > The EC_CMD_PWM_{GET,SET}_DUTY commands allow us to control a PWM that is > > attached to the EC, rather than the main host SoC. The API provides > > functionality-based (e.g., keyboard light, b

Re: [PATCH v2 2/4] mfd: cros_ec: add EC_PWM function definitions

2016-06-17 Thread Brian Norris
On Fri, Jun 17, 2016 at 05:55:52PM +0200, Thierry Reding wrote: > On Fri, Jun 17, 2016 at 09:06:35AM +0100, Lee Jones wrote: > > On Thu, 16 Jun 2016, Doug Anderson wrote: > > > On Thu, Jun 16, 2016 at 8:38 AM, Lee Jones wrote: [...] > > > > Please use kerneldoc format. [...] > > > Probably the

Re: [PATCH v2 2/4] mfd: cros_ec: add EC_PWM function definitions

2016-06-17 Thread Thierry Reding
On Fri, Jun 17, 2016 at 09:06:35AM +0100, Lee Jones wrote: > On Thu, 16 Jun 2016, Doug Anderson wrote: > > On Thu, Jun 16, 2016 at 8:38 AM, Lee Jones wrote: > > > On Thu, 02 Jun 2016, Brian Norris wrote: > > > > > >> The EC_CMD_PWM_{GET,SET}_DUTY commands allow us to control a PWM that is > > >> a

Re: [PATCH v2 2/4] mfd: cros_ec: add EC_PWM function definitions

2016-06-17 Thread Doug Anderson
Lee, On Fri, Jun 17, 2016 at 1:06 AM, Lee Jones wrote: >> Probably the reason for all of these non-kernel-isms is that this >> isn't a kernel file. From the top of the file: >> >> * NOTE: This file is copied verbatim from the ChromeOS EC Open Source >> * project in an attempt to make future up

Re: [PATCH v2 2/4] mfd: cros_ec: add EC_PWM function definitions

2016-06-17 Thread Lee Jones
On Thu, 16 Jun 2016, Doug Anderson wrote: > On Thu, Jun 16, 2016 at 8:38 AM, Lee Jones wrote: > > On Thu, 02 Jun 2016, Brian Norris wrote: > > > >> The EC_CMD_PWM_{GET,SET}_DUTY commands allow us to control a PWM that is > >> attached to the EC, rather than the main host SoC. The API provides > >>

Re: [PATCH v2 2/4] mfd: cros_ec: add EC_PWM function definitions

2016-06-16 Thread Doug Anderson
Lee, On Thu, Jun 16, 2016 at 8:38 AM, Lee Jones wrote: > On Thu, 02 Jun 2016, Brian Norris wrote: > >> The EC_CMD_PWM_{GET,SET}_DUTY commands allow us to control a PWM that is >> attached to the EC, rather than the main host SoC. The API provides >> functionality-based (e.g., keyboard light, back

Re: [PATCH v2 2/4] mfd: cros_ec: add EC_PWM function definitions

2016-06-16 Thread Lee Jones
On Thu, 02 Jun 2016, Brian Norris wrote: > The EC_CMD_PWM_{GET,SET}_DUTY commands allow us to control a PWM that is > attached to the EC, rather than the main host SoC. The API provides > functionality-based (e.g., keyboard light, backlight) or index-based > addressing of the PWM(s). Duty cycles a

[PATCH v2 2/4] mfd: cros_ec: add EC_PWM function definitions

2016-06-02 Thread Brian Norris
The EC_CMD_PWM_{GET,SET}_DUTY commands allow us to control a PWM that is attached to the EC, rather than the main host SoC. The API provides functionality-based (e.g., keyboard light, backlight) or index-based addressing of the PWM(s). Duty cycles are represented by a 16-bit value, where 0 maps to