Re: [PATCH v2 2/4] Input: omap4-keypad - Fix handling of platform_get_irq() error

2020-09-15 Thread Dmitry Torokhov
On Tue, Sep 15, 2020 at 11:06 PM Krzysztof Kozlowski wrote: > > On Wed, 16 Sep 2020 at 02:54, Dmitry Torokhov > wrote: > > > > On Fri, Aug 28, 2020 at 04:57:42PM +0200, Krzysztof Kozlowski wrote: > > > platform_get_irq() returns -ERRNO on error. In such case comparison > > > to 0 would pass the

Re: [PATCH v2 2/4] Input: omap4-keypad - Fix handling of platform_get_irq() error

2020-09-15 Thread Krzysztof Kozlowski
On Wed, 16 Sep 2020 at 02:54, Dmitry Torokhov wrote: > > On Fri, Aug 28, 2020 at 04:57:42PM +0200, Krzysztof Kozlowski wrote: > > platform_get_irq() returns -ERRNO on error. In such case comparison > > to 0 would pass the check. > > > > Fixes: f3a1ba60dbdb ("Input: omap4-keypad - use platform dev

Re: [PATCH v2 2/4] Input: omap4-keypad - Fix handling of platform_get_irq() error

2020-09-15 Thread Dmitry Torokhov
On Fri, Aug 28, 2020 at 04:57:42PM +0200, Krzysztof Kozlowski wrote: > platform_get_irq() returns -ERRNO on error. In such case comparison > to 0 would pass the check. > > Fixes: f3a1ba60dbdb ("Input: omap4-keypad - use platform device helpers") > Signed-off-by: Krzysztof Kozlowski > > --- > >

[PATCH v2 2/4] Input: omap4-keypad - Fix handling of platform_get_irq() error

2020-08-28 Thread Krzysztof Kozlowski
platform_get_irq() returns -ERRNO on error. In such case comparison to 0 would pass the check. Fixes: f3a1ba60dbdb ("Input: omap4-keypad - use platform device helpers") Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. None --- drivers/input/keyboard/omap4-keypad.c | 6 ++ 1 fil