Re: [PATCH v2 2/3] media: i2c: Add IMX290 CMOS image sensor driver

2019-08-29 Thread Sakari Ailus
Hi Manivannan, On Thu, Aug 29, 2019 at 10:34:15PM +0530, Manivannan Sadhasivam wrote: ... > > > +static int imx290_set_fmt(struct v4l2_subdev *sd, > > > + struct v4l2_subdev_pad_config *cfg, > > > + struct v4l2_subdev_format *fmt) > > > +{ > > > + struct imx290 *i

Re: [PATCH v2 2/3] media: i2c: Add IMX290 CMOS image sensor driver

2019-08-29 Thread Manivannan Sadhasivam
Hi Sakari, Thanks for the review! On Tue, Aug 13, 2019 at 01:59:20PM +0300, Sakari Ailus wrote: > Hi Manivannan, > > On Tue, Aug 06, 2019 at 06:39:37PM +0530, Manivannan Sadhasivam wrote: > > Add driver for Sony IMX290 CMOS image sensor driver. The driver only > > supports I2C interface for prog

Re: [PATCH v2 2/3] media: i2c: Add IMX290 CMOS image sensor driver

2019-08-13 Thread Sakari Ailus
Hi Manivannan, On Tue, Aug 06, 2019 at 06:39:37PM +0530, Manivannan Sadhasivam wrote: > Add driver for Sony IMX290 CMOS image sensor driver. The driver only > supports I2C interface for programming and MIPI CSI-2 for sensor output. > > Signed-off-by: Manivannan Sadhasivam > --- > drivers/media/

[PATCH v2 2/3] media: i2c: Add IMX290 CMOS image sensor driver

2019-08-06 Thread Manivannan Sadhasivam
Add driver for Sony IMX290 CMOS image sensor driver. The driver only supports I2C interface for programming and MIPI CSI-2 for sensor output. Signed-off-by: Manivannan Sadhasivam --- drivers/media/i2c/Kconfig | 11 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/imx290.c | 845