Re: [PATCH v2 2/3] i2c-mux-gpio: Unpin the platform-specific GPIOs request code

2019-06-14 Thread Serge Semin
On Fri, Jun 14, 2019 at 06:04:33PM +, Peter Rosin wrote: > On 2019-06-14 18:31, Serge Semin wrote: > > Hello Peter, > > > > On Sun, Jun 09, 2019 at 09:34:54PM +, Peter Rosin wrote: > >> On 2019-04-26 01:20, Serge Semin wrote: > >>> The GPIOs request loop can be safely moved to a separate f

Re: [PATCH v2 2/3] i2c-mux-gpio: Unpin the platform-specific GPIOs request code

2019-06-14 Thread Peter Rosin
On 2019-06-14 18:31, Serge Semin wrote: > Hello Peter, > > On Sun, Jun 09, 2019 at 09:34:54PM +, Peter Rosin wrote: >> On 2019-04-26 01:20, Serge Semin wrote: >>> The GPIOs request loop can be safely moved to a separate function. >>> First of all it shall improve the code readability. Secondly

Re: [PATCH v2 2/3] i2c-mux-gpio: Unpin the platform-specific GPIOs request code

2019-06-14 Thread Serge Semin
Hello Peter, On Sun, Jun 09, 2019 at 09:34:54PM +, Peter Rosin wrote: > On 2019-04-26 01:20, Serge Semin wrote: > > The GPIOs request loop can be safely moved to a separate function. > > First of all it shall improve the code readability. Secondly the > > initialization loop at this point is u

Re: [PATCH v2 2/3] i2c-mux-gpio: Unpin the platform-specific GPIOs request code

2019-06-09 Thread Peter Rosin
On 2019-04-26 01:20, Serge Semin wrote: > The GPIOs request loop can be safely moved to a separate function. > First of all it shall improve the code readability. Secondly the > initialization loop at this point is used for both of- and > platform_data-based initialization paths, but it will be cha

[PATCH v2 2/3] i2c-mux-gpio: Unpin the platform-specific GPIOs request code

2019-04-25 Thread Serge Semin
The GPIOs request loop can be safely moved to a separate function. First of all it shall improve the code readability. Secondly the initialization loop at this point is used for both of- and platform_data-based initialization paths, but it will be changed in the next patch, so by isolating the code