Re: [PATCH v2 2/3] Support for perf to probe into SDT markers:

2013-10-08 Thread Hemant
On 10/08/2013 05:17 PM, Masami Hiramatsu wrote: (2013/10/07 15:48), Hemant Kumar wrote: [...] diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c index cbd2383..6f09723 100644 --- a/tools/perf/builtin-probe.c +++ b/tools/perf/builtin-probe.c @@ -370,6 +370,17 @@ int cmd_probe(in

Re: [PATCH v2 2/3] Support for perf to probe into SDT markers:

2013-10-08 Thread Hemant
On 10/08/2013 02:39 PM, Namhyung Kim wrote: [...] + + tmp = strdup(ptr); + if (!tmp) + return -ENOMEM; These -ENOMEM returning should free all memory region allocated previously. Yes, missed that. + pev->point.note->name = tmp;

Re: [PATCH v2 2/3] Support for perf to probe into SDT markers:

2013-10-08 Thread Masami Hiramatsu
(2013/10/07 15:48), Hemant Kumar wrote: > This allows perf to probe into the sdt markers/notes present in > the libraries and executables. We try to find the associated location > and handle prelinking (since, stapsdt notes section is not allocated > during runtime). Prelinking is handled with the

Re: [PATCH v2 2/3] Support for perf to probe into SDT markers:

2013-10-08 Thread Namhyung Kim
On Mon, 07 Oct 2013 12:18:29 +0530, Hemant Kumar wrote: > This allows perf to probe into the sdt markers/notes present in > the libraries and executables. We try to find the associated location > and handle prelinking (since, stapsdt notes section is not allocated > during runtime). Prelinking is h

[PATCH v2 2/3] Support for perf to probe into SDT markers:

2013-10-06 Thread Hemant Kumar
This allows perf to probe into the sdt markers/notes present in the libraries and executables. We try to find the associated location and handle prelinking (since, stapsdt notes section is not allocated during runtime). Prelinking is handled with the help of base section which is allocated during r