Re: [Linux-kernel-mentees] [PATCH v2 2/3] PCI: sysfs: Change permissions from symbolic to octal

2019-09-04 Thread Kelsey Skunberg
On Wed, Sep 04, 2019 at 02:33:44PM -0400, Don Dutile wrote: > On 09/04/2019 02:22 AM, Kelsey Skunberg wrote: > > On Thu, Aug 15, 2019 at 10:37:13AM -0400, Don Dutile wrote: > > > On 08/14/2019 01:38 AM, Bjorn Helgaas wrote: > > > > [+cc Bodong, Don, Greg for permission question] > > > > > > > > On

Re: [Linux-kernel-mentees] [PATCH v2 2/3] PCI: sysfs: Change permissions from symbolic to octal

2019-09-04 Thread Don Dutile
On 09/04/2019 02:22 AM, Kelsey Skunberg wrote: On Thu, Aug 15, 2019 at 10:37:13AM -0400, Don Dutile wrote: On 08/14/2019 01:38 AM, Bjorn Helgaas wrote: [+cc Bodong, Don, Greg for permission question] On Tue, Aug 13, 2019 at 02:45:12PM -0600, Kelsey Skunberg wrote: Symbolic permissions such as

Re: [Linux-kernel-mentees] [PATCH v2 2/3] PCI: sysfs: Change permissions from symbolic to octal

2019-09-04 Thread Don Dutile
On 09/04/2019 02:22 AM, Kelsey Skunberg wrote: On Thu, Aug 15, 2019 at 10:37:13AM -0400, Don Dutile wrote: On 08/14/2019 01:38 AM, Bjorn Helgaas wrote: [+cc Bodong, Don, Greg for permission question] On Tue, Aug 13, 2019 at 02:45:12PM -0600, Kelsey Skunberg wrote: Symbolic permissions such as

Re: [Linux-kernel-mentees] [PATCH v2 2/3] PCI: sysfs: Change permissions from symbolic to octal

2019-09-03 Thread Kelsey Skunberg
On Thu, Aug 15, 2019 at 10:37:13AM -0400, Don Dutile wrote: > On 08/14/2019 01:38 AM, Bjorn Helgaas wrote: > > [+cc Bodong, Don, Greg for permission question] > > > > On Tue, Aug 13, 2019 at 02:45:12PM -0600, Kelsey Skunberg wrote: > > > Symbolic permissions such as "(S_IWUSR | S_IWGRP)" are not >

Re: [Linux-kernel-mentees] [PATCH v2 2/3] PCI: sysfs: Change permissions from symbolic to octal

2019-08-15 Thread Don Dutile
On 08/14/2019 01:38 AM, Bjorn Helgaas wrote: [+cc Bodong, Don, Greg for permission question] On Tue, Aug 13, 2019 at 02:45:12PM -0600, Kelsey Skunberg wrote: Symbolic permissions such as "(S_IWUSR | S_IWGRP)" are not preferred and octal permissions should be used instead. Change all symbolic pe

Re: [Linux-kernel-mentees] [PATCH v2 2/3] PCI: sysfs: Change permissions from symbolic to octal

2019-08-14 Thread Greg Kroah-Hartman
On Wed, Aug 14, 2019 at 12:38:46AM -0500, Bjorn Helgaas wrote: > [+cc Bodong, Don, Greg for permission question] > > On Tue, Aug 13, 2019 at 02:45:12PM -0600, Kelsey Skunberg wrote: > > Symbolic permissions such as "(S_IWUSR | S_IWGRP)" are not > > preferred and octal permissions should be used in

Re: [Linux-kernel-mentees] [PATCH v2 2/3] PCI: sysfs: Change permissions from symbolic to octal

2019-08-13 Thread Bjorn Helgaas
[+cc Bodong, Don, Greg for permission question] On Tue, Aug 13, 2019 at 02:45:12PM -0600, Kelsey Skunberg wrote: > Symbolic permissions such as "(S_IWUSR | S_IWGRP)" are not > preferred and octal permissions should be used instead. Change all > symbolic permissions to octal permissions. > > Examp

[PATCH v2 2/3] PCI: sysfs: Change permissions from symbolic to octal

2019-08-13 Thread Kelsey Skunberg
Symbolic permissions such as "(S_IWUSR | S_IWGRP)" are not preferred and octal permissions should be used instead. Change all symbolic permissions to octal permissions. Example of old: "(S_IWUSR | S_IWGRP)" Example of new: "0220" Signed-off-by: Kelsey Skunberg --- drivers/pci/pci-sysfs.c | 2