Re: [PATCH v2 2/3] Input: add a driver for GPIO controllable vibrators

2019-04-09 Thread Luca Weiss
Hello Dmitry, see inline comments - and: your last two comments should probably be also applied to the pwm-vibra.c driver, as that's where these code blocks come from. On Montag, 8. April 2019 00:18:57 CEST Dmitry Torokhov wrote: > Hi Luca, > > On Sun, Apr 07, 2019 at 05:58:41PM +0200, Luca Wei

Re: [PATCH v2 2/3] Input: add a driver for GPIO controllable vibrators

2019-04-07 Thread Dmitry Torokhov
Hi Luca, On Sun, Apr 07, 2019 at 05:58:41PM +0200, Luca Weiss wrote: > Provide a simple driver for GPIO controllable vibrators. > It will be used by the Fairphone 2. > > Signed-off-by: Luca Weiss > --- > drivers/input/misc/Kconfig | 12 ++ > drivers/input/misc/Makefile | 1 + > driv

[PATCH v2 2/3] Input: add a driver for GPIO controllable vibrators

2019-04-07 Thread Luca Weiss
Provide a simple driver for GPIO controllable vibrators. It will be used by the Fairphone 2. Signed-off-by: Luca Weiss --- drivers/input/misc/Kconfig | 12 ++ drivers/input/misc/Makefile | 1 + drivers/input/misc/gpio-vibra.c | 214 3 files changed, 2