Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver

2016-08-02 Thread David Daney
On 08/02/2016 02:30 PM, Mark Brown wrote: On Mon, Aug 01, 2016 at 12:02:54PM -0700, David Daney wrote: On 08/01/2016 11:49 AM, Mark Brown wrote: What is that thing on ACPI systems? I don't know if it works ACPI, or if ACPI even has support for the clock framework. But does it matter? We

Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver

2016-08-02 Thread Mark Brown
On Mon, Aug 01, 2016 at 12:02:54PM -0700, David Daney wrote: > On 08/01/2016 11:49 AM, Mark Brown wrote: > > What is that thing on ACPI systems? > I don't know if it works ACPI, or if ACPI even has support for the clock > framework. But does it matter? We are not currently using ACPI on systems

Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver

2016-08-01 Thread David Daney
On 08/01/2016 11:49 AM, Mark Brown wrote: On Mon, Aug 01, 2016 at 11:31:43AM -0700, David Daney wrote: On 08/01/2016 10:28 AM, Mark Brown wrote: On Thu, Jul 28, 2016 at 10:31:44AM +0200, Jan Glauber wrote: + p->clk = devm_clk_get(dev, NULL); + if (IS_ERR(p->clk)) +

Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver

2016-08-01 Thread Mark Brown
On Mon, Aug 01, 2016 at 11:31:43AM -0700, David Daney wrote: > On 08/01/2016 10:28 AM, Mark Brown wrote: > > On Thu, Jul 28, 2016 at 10:31:44AM +0200, Jan Glauber wrote: > > > + p->clk = devm_clk_get(dev, NULL); > > > + if (IS_ERR(p->clk)) > > > + goto out_unmap; > > We're now just using

Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver

2016-08-01 Thread David Daney
On 08/01/2016 10:28 AM, Mark Brown wrote: On Thu, Jul 28, 2016 at 10:31:44AM +0200, Jan Glauber wrote: +config SPI_THUNDERX + tristate "Cavium ThunderX SPI controller" + depends on (ARM64 || CONFIG_TEST) && 64BIT && PCI You mean COMPILE_TEST. Yes, we will fix that typo. +

Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver

2016-08-01 Thread Mark Brown
On Thu, Jul 28, 2016 at 10:31:44AM +0200, Jan Glauber wrote: > +config SPI_THUNDERX > + tristate "Cavium ThunderX SPI controller" > + depends on (ARM64 || CONFIG_TEST) && 64BIT && PCI You mean COMPILE_TEST. > + p->clk = devm_clk_get(dev, NULL); > + if (IS_ERR(p->clk)) > +

[PATCH v2 2/2] spi: octeon: Add thunderx driver

2016-07-28 Thread Jan Glauber
Add ThunderX SPI driver using the shared part from the Octeon driver. The main difference of the ThunderX driver is that it is a PCI device so probing is different. The system clock settings can be specified in device tree. Signed-off-by: Jan Glauber --- drivers/spi/Kconfig | 7 +