Re: [PATCH v2 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-04-08 Thread Thierry Reding
On Thu, Apr 08, 2021 at 09:59:20AM +0200, Uwe Kleine-König wrote: > Hello Nobuhiro, > > On Thu, Apr 08, 2021 at 08:15:48AM +0900, Nobuhiro Iwamatsu wrote: > > > > + /* > > > > +* pwmc is a 2-bit divider for the input clock running at 1 MHz. > > > > +* When the settings of the

Re: [PATCH v2 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-04-08 Thread Uwe Kleine-König
Hello Nobuhiro, On Thu, Apr 08, 2021 at 08:15:48AM +0900, Nobuhiro Iwamatsu wrote: > > > + /* > > > + * pwmc is a 2-bit divider for the input clock running at 1 MHz. > > > + * When the settings of the PWM are modified, the new values are > > > shadowed in hardware until > > > + * the period re

Re: [PATCH v2 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-04-07 Thread Nobuhiro Iwamatsu
Hi, Thanks for your review. On Fri, Feb 12, 2021 at 05:41:44PM +0100, Uwe Kleine-König wrote: > Hello Nobuhiro, > > On Fri, Feb 12, 2021 at 10:19:10PM +0900, Nobuhiro Iwamatsu wrote: > > Add driver for the PWM controller on Toshiba Visconti ARM SoC. > > > > Signed-off-by: Nobuhiro Iwamatsu > >

Re: [PATCH v2 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-02-12 Thread Uwe Kleine-König
Hello Nobuhiro, On Fri, Feb 12, 2021 at 10:19:10PM +0900, Nobuhiro Iwamatsu wrote: > Add driver for the PWM controller on Toshiba Visconti ARM SoC. > > Signed-off-by: Nobuhiro Iwamatsu > --- > drivers/pwm/Kconfig| 9 ++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-visconti.

[PATCH v2 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-02-12 Thread Nobuhiro Iwamatsu
Add driver for the PWM controller on Toshiba Visconti ARM SoC. Signed-off-by: Nobuhiro Iwamatsu --- drivers/pwm/Kconfig| 9 ++ drivers/pwm/Makefile | 1 + drivers/pwm/pwm-visconti.c | 173 + 3 files changed, 183 insertions(+) create mode 100