Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-09-11 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > I haven't performed all these tests when running on an older kernel, > just checked that PERF_RECORD_MMAP was present, PERF_RECORD_MMAP2, as > expected, were not, probably they will be present only for the > synthesized events, right? The ones coming from t

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-09-11 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 11, 2013 at 04:42:57PM +0200, Stephane Eranian escreveu: > Arnaldo, > > Do you have all those changes in a git tree somewhere. > I want to help test and debug this part too. > Thanks. Right now its all in my perf/urgent branch at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/li

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-09-11 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 11, 2013 at 11:53:41AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Sep 11, 2013 at 04:42:57PM +0200, Stephane Eranian escreveu: > > Do you have all those changes in a git tree somewhere. > > I want to help test and debug this part too. > > Thanks. > Right now its all in my per

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-09-11 Thread Stephane Eranian
Arnaldo, Do you have all those changes in a git tree somewhere. I want to help test and debug this part too. Thanks. On Tue, Sep 10, 2013 at 10:16 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 10, 2013 at 04:58:47PM -0300, Arnaldo Carvalho de Melo escreveu: >> So we must have the handling w

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-09-10 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 10, 2013 at 04:58:47PM -0300, Arnaldo Carvalho de Melo escreveu: > So we must have the handling we have for other things that were added > in the past, like .sample_id_all, .exclude_guest, etc, like is done in > the attached patch, please ack. > > Ingo, since you haven't merged my late

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-09-10 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 10, 2013 at 10:17:28AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Sep 10, 2013 at 03:05:03PM +0200, Stephane Eranian escreveu: > > On Tue, Sep 10, 2013 at 3:00 PM, Arnaldo Carvalho de Melo > > wrote: > > > Em Mon, Sep 09, 2013 at 04:48:44PM -0300, Arnaldo Carvalho de Melo >

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-09-10 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 10, 2013 at 03:05:03PM +0200, Stephane Eranian escreveu: > On Tue, Sep 10, 2013 at 3:00 PM, Arnaldo Carvalho de Melo > wrote: > > Em Mon, Sep 09, 2013 at 04:48:44PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Mon, Sep 09, 2013 at 04:47:45PM -0300, Arnaldo Carvalho de Melo > >

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-09-10 Thread Stephane Eranian
On Tue, Sep 10, 2013 at 3:00 PM, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Sep 09, 2013 at 04:48:44PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Sep 09, 2013 at 04:47:45PM -0300, Arnaldo Carvalho de Melo escreveu: > > > I noticed the kernel part is in, and I'm going to use MMAP2 on

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-09-10 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 09, 2013 at 04:48:44PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Sep 09, 2013 at 04:47:45PM -0300, Arnaldo Carvalho de Melo escreveu: > > I noticed the kernel part is in, and I'm going to use MMAP2 on that new > > tool, so tried merging it, but: > > > > I fixed it up wrt ano

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-09-10 Thread Peter Zijlstra
On Mon, Sep 09, 2013 at 04:47:45PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Aug 21, 2013 at 12:10:25PM +0200, Stephane Eranian escreveu: > > This patch adds support for the new PERF_RECORD_MMAP2 > > record type exposed by the kernel. This is an extended > > PERF_RECORD_MMAP record. It adds

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-09-09 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 09, 2013 at 04:47:45PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Aug 21, 2013 at 12:10:25PM +0200, Stephane Eranian escreveu: > > This patch adds support for the new PERF_RECORD_MMAP2 > > record type exposed by the kernel. This is an extended > > PERF_RECORD_MMAP record. It ad

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-09-09 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 21, 2013 at 12:10:25PM +0200, Stephane Eranian escreveu: > This patch adds support for the new PERF_RECORD_MMAP2 > record type exposed by the kernel. This is an extended > PERF_RECORD_MMAP record. It adds for each file-backed > mapping the device major, minor number and the inode > numb

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-08-30 Thread Ingo Molnar
* Stephane Eranian wrote: > False alarm, the changes in builtin-inject.c are in V2. Nothing more to > do. Sorry about the confusion. ok, I'll pick up the -v2 patches from Peter. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-08-30 Thread Stephane Eranian
False alarm, the changes in builtin-inject.c are in V2. Nothing more to do. Sorry about the confusion. On Fri, Aug 30, 2013 at 4:15 PM, Stephane Eranian wrote: > On Fri, Aug 30, 2013 at 4:08 PM, Peter Zijlstra wrote: >> On Fri, Aug 30, 2013 at 04:03:26PM +0200, Stephane Eranian wrote: >>> Hi, >

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-08-30 Thread Stephane Eranian
On Fri, Aug 30, 2013 at 4:08 PM, Peter Zijlstra wrote: > On Fri, Aug 30, 2013 at 04:03:26PM +0200, Stephane Eranian wrote: >> Hi, >> >> I realized I have forgotten to patch builtin-inject.c to repipe mmap2 >> records. >> Will resubmit V3. > > OK, I already queued the previous two, it looked fine

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-08-30 Thread Peter Zijlstra
On Fri, Aug 30, 2013 at 04:03:26PM +0200, Stephane Eranian wrote: > Hi, > > I realized I have forgotten to patch builtin-inject.c to repipe mmap2 records. > Will resubmit V3. OK, I already queued the previous two, it looked fine and the ack was long in coming. If mingo manages to push out before

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-08-30 Thread Stephane Eranian
Hi, I realized I have forgotten to patch builtin-inject.c to repipe mmap2 records. Will resubmit V3. On Thu, Aug 22, 2013 at 12:51 PM, Peter Zijlstra wrote: > On Wed, Aug 21, 2013 at 12:10:25PM +0200, Stephane Eranian wrote: >> This patch adds support for the new PERF_RECORD_MMAP2 >> record typ

Re: [PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-08-22 Thread Peter Zijlstra
On Wed, Aug 21, 2013 at 12:10:25PM +0200, Stephane Eranian wrote: > This patch adds support for the new PERF_RECORD_MMAP2 > record type exposed by the kernel. This is an extended > PERF_RECORD_MMAP record. It adds for each file-backed > mapping the device major, minor number and the inode > number

[PATCH v2 2/2] perf tools: add attr->mmap2 support

2013-08-21 Thread Stephane Eranian
This patch adds support for the new PERF_RECORD_MMAP2 record type exposed by the kernel. This is an extended PERF_RECORD_MMAP record. It adds for each file-backed mapping the device major, minor number and the inode number and generation. This triplet uniquely identifies the source of a file-backed