Re: [PATCH v2 2/2] module: Add module name to modinfo

2017-04-25 Thread Jessica Yu
+++ Jon Masters [25/04/17 03:04 -0400]: Nevermind. Missread the patch as doing something different on first pass. It's good to give the kmod folks a heads up anyway (as name would be visible in modinfo), thanks Jon! On Apr 25, 2017, at 03:00, Jon Masters wrote: On 04/21/2017 06:35 PM, Kees

Re: [PATCH v2 2/2] module: Add module name to modinfo

2017-04-25 Thread Jon Masters
Nevermind. Missread the patch as doing something different on first pass. -- Computer Architect | Sent from my 64-bit #ARM Powered phone > On Apr 25, 2017, at 03:00, Jon Masters wrote: > >> On 04/21/2017 06:35 PM, Kees Cook wrote: >> >> Accessing the mod structure (e.g. for mod->name) prior t

Re: [PATCH v2 2/2] module: Add module name to modinfo

2017-04-25 Thread Jon Masters
On 04/21/2017 06:35 PM, Kees Cook wrote: > Accessing the mod structure (e.g. for mod->name) prior to having completed > check_modstruct_version() can result in writing garbage to the error logs > if the layout of the mod structure loaded from disk doesn't match the > running kernel's mod structure

[PATCH v2 2/2] module: Add module name to modinfo

2017-04-21 Thread Kees Cook
Accessing the mod structure (e.g. for mod->name) prior to having completed check_modstruct_version() can result in writing garbage to the error logs if the layout of the mod structure loaded from disk doesn't match the running kernel's mod structure layout. This kind of mismatch will become much mo