Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-06-05 Thread Andy Shevchenko
On Sun, 2016-06-05 at 08:34 -0700, Joe Perches wrote: > On Sun, 2016-06-05 at 17:19 +0300, Andy Shevchenko wrote: > > On Sat, 2016-06-04 at 09:29 -0700, Joe Perches wrote: > > > (adding acpi folks) > > > Trivially, acpi defines this but doesn't seem to use it. > > > > > > include/acpi/acconfig.h:#

Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-06-05 Thread Joe Perches
On Sun, 2016-06-05 at 17:19 +0300, Andy Shevchenko wrote: > On Sat, 2016-06-04 at 09:29 -0700, Joe Perches wrote: > > (adding acpi folks) > > Trivially, acpi defines this but doesn't seem to use it. > > > > include/acpi/acconfig.h:#define UUID_STRING_LENGTH  36  /* > > Total length of a UU

Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-06-05 Thread Andy Shevchenko
On Sat, 2016-06-04 at 09:29 -0700, Joe Perches wrote: > (adding acpi folks) > > Trivially, acpi defines this but doesn't seem to use it. > > include/acpi/acconfig.h:#define UUID_STRING_LENGTH  36  /* > Total length of a UUID string */ > > And Ingo commented last month: > https://lkml.o

Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-06-04 Thread George Spelvin
Joe Perches wrote: > And Ingo commented last month: > https://lkml.org/lkml/2016/4/29/69 > > Maybe this __uuid_to_bin function should be made public and > the acpi version in drivers/acpi/acpica/utuuid.c should be > removed. I agree with the second part, but not the first; the uuid_le_to_bin() wra

Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-06-04 Thread Joe Perches
(adding acpi folks) On Sat, 2016-06-04 at 01:14 -0400, George Spelvin wrote: > Both input and output code is simplified if we use a mapping from binary > UUID index to ASCII UUID position.  This lets us combine hyphen-skipping > and endian-swapping into one table. > > This significantly simplifie

Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-06-03 Thread kbuild test robot
Hi, [auto build test WARNING on v4.7-rc1] [cannot apply to next-20160603] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/George-Spelvin/Clean-up-and-shrink-uuid-input-output/20160604-131729 conf

[PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

2016-06-03 Thread George Spelvin
Both input and output code is simplified if we use a mapping from binary UUID index to ASCII UUID position. This lets us combine hyphen-skipping and endian-swapping into one table. This significantly simplifies __uuid_to_bin(), which was using *two* lookup tables. uuid_[bl]e_index were EXPORT_SY