Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

2016-10-28 Thread John Stultz
On Fri, Oct 28, 2016 at 5:34 AM, Leo Yan wrote: > On Fri, Oct 28, 2016 at 08:52:49PM +0900, Jaehoon Chung wrote: > > [...] > >> >> Could you check the below thing.. >> >> >> >> /* find reset controller when exist */ >> >> - pdata->rstc = devm_reset_control_get_optional(dev, NULL); >>

Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

2016-10-28 Thread Leo Yan
On Fri, Oct 28, 2016 at 08:52:49PM +0900, Jaehoon Chung wrote: [...] > >> Could you check the below thing.. > >> > >> /* find reset controller when exist */ > >> - pdata->rstc = devm_reset_control_get_optional(dev, NULL); > >> + pdata->rstc = devm_reset_control_get_optional(de

Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

2016-10-28 Thread Jaehoon Chung
Hi, On 10/28/2016 07:19 PM, Leo Yan wrote: > On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote: > > [...] > > Could you share the log? Is there any log about failure? Sure, please see below log: >>> >>> It's related with -EPROBE_DEFER..I'm not sure but if >>> CONFIG_RE

Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

2016-10-28 Thread Leo Yan
On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote: [...] > >>> Could you share the log? Is there any log about failure? > >> > >> Sure, please see below log: > > > > It's related with -EPROBE_DEFER..I'm not sure but if > > CONFIG_RESET_CONTROLLER is enabled, it's searching for reset

Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

2016-10-28 Thread Jaehoon Chung
Hi, On 10/28/2016 06:43 PM, Jaehoon Chung wrote: > Hi, > > On 10/28/2016 04:38 PM, Leo Yan wrote: >> On Fri, Oct 28, 2016 at 04:33:41PM +0900, Jaehoon Chung wrote: >> >> [...] >> >> Guodong: Is there any bootloader dependency on that change? > > FYI, I use firmwares available in AOSP

Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

2016-10-28 Thread Jaehoon Chung
Hi, On 10/28/2016 04:38 PM, Leo Yan wrote: > On Fri, Oct 28, 2016 at 04:33:41PM +0900, Jaehoon Chung wrote: > > [...] > > Guodong: Is there any bootloader dependency on that change? FYI, I use firmwares available in AOSP >>> >>> I tried latest firmware [1], still cannot boot up unt

Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

2016-10-28 Thread Jaehoon Chung
Hi, On 10/28/2016 04:26 PM, Leo Yan wrote: > On Fri, Oct 28, 2016 at 08:43:51AM +0200, Vincent Guittot wrote: > > [...] > >>> running with? Also do you have any details about the card in case its >>> card specific? >> >> The sdcard is quite common: sandisk ultra 16GB >> and my rootfs is on the s

Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

2016-10-28 Thread Leo Yan
On Fri, Oct 28, 2016 at 04:33:41PM +0900, Jaehoon Chung wrote: [...] > >>> Guodong: Is there any bootloader dependency on that change? > >> > >> FYI, I use firmwares available in AOSP > > > > I tried latest firmware [1], still cannot boot up until revert the > > patch "arm64: dts: hi6220: add re

Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

2016-10-28 Thread Leo Yan
On Fri, Oct 28, 2016 at 08:43:51AM +0200, Vincent Guittot wrote: [...] > > running with? Also do you have any details about the card in case its > > card specific? > > The sdcard is quite common: sandisk ultra 16GB > and my rootfs is on the sdcard I'm using rootfs in emmc also have same failure

Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

2016-10-27 Thread John Stultz
On Thu, Oct 27, 2016 at 6:56 AM, Vincent Guittot wrote: > > My hikey board failed to detect and mount sdcard with v4.9-rc1 and i > have bisected the issue to this patch. Once reverted, the sdcard is > detected again. Hrm.. I've not seen this w/ my v4.9-rc2 based tree, and I don't have any mmc pat

Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

2016-10-27 Thread Vincent Guittot
Hi, My hikey board failed to detect and mount sdcard with v4.9-rc1 and i have bisected the issue to this patch. Once reverted, the sdcard is detected again. Regards, Vincent On 25 August 2016 at 05:00, Guodong Xu wrote: > Add resets property into dwmmc_0, dwmmc_1 and dwmmc_2 for hi6220 > > Code

[PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes

2016-08-24 Thread Guodong Xu
Add resets property into dwmmc_0, dwmmc_1 and dwmmc_2 for hi6220 Code and documentation to this property were confirmed by maintainers. See: [1] https://patchwork.kernel.org/patch/9276607/ [2] https://patchwork.kernel.org/patch/8487151/ [3] https://lkml.org/lkml/2016/8/12/91 cc: Jaehoon Chung cc