Re: [PATCH v2 16/27] perf evlist: Warn as events from different hybrid PMUs in a group

2021-03-18 Thread Jiri Olsa
On Tue, Mar 16, 2021 at 01:25:29PM +0800, Jin, Yao wrote: > Hi Jiri, > > On 3/16/2021 7:03 AM, Jiri Olsa wrote: > > On Thu, Mar 11, 2021 at 03:07:31PM +0800, Jin Yao wrote: > > > > SNIP > > > > > goto try_again; > > > } > > > + > > > +

Re: [PATCH v2 16/27] perf evlist: Warn as events from different hybrid PMUs in a group

2021-03-15 Thread Jin, Yao
Hi Jiri, On 3/16/2021 7:03 AM, Jiri Olsa wrote: On Thu, Mar 11, 2021 at 03:07:31PM +0800, Jin Yao wrote: SNIP goto try_again; } + + if (errno == EINVAL && perf_pmu__hybrid_exist()) + ev

Re: [PATCH v2 16/27] perf evlist: Warn as events from different hybrid PMUs in a group

2021-03-15 Thread Jiri Olsa
On Thu, Mar 11, 2021 at 03:07:31PM +0800, Jin Yao wrote: SNIP > goto try_again; > } > + > + if (errno == EINVAL && perf_pmu__hybrid_exist()) > + evlist__warn_hybrid_group(evlist); >

[PATCH v2 16/27] perf evlist: Warn as events from different hybrid PMUs in a group

2021-03-10 Thread Jin Yao
If a group has events which are from different hybrid PMUs, shows a warning. This is to remind the user not to put the core event and atom event into one group. root@ssp-pwrt-002:~# ./perf stat -e "{cpu_core/cycles/,cpu_atom/cycles/}" -- sleep 1 WARNING: Group has events from different hybri