On 13.09.24 00:37, Sami Tolvanen wrote:
> Hi,
>
> On Thu, Sep 12, 2024 at 2:58 PM Benno Lossin wrote:
>>
>> On 12.09.24 22:58, Sami Tolvanen wrote:
>>> That's an interesting point. Is the problem that you cannot assign
>>> arbitrary values to the Rust enum that bindgen generates, or is using
>>>
Hi,
On Thu, Sep 12, 2024 at 2:58 PM Benno Lossin wrote:
>
> On 12.09.24 22:58, Sami Tolvanen wrote:
> > That's an interesting point. Is the problem that you cannot assign
> > arbitrary values to the Rust enum that bindgen generates, or is using
> > a #define the problem? We could probably just ma
On 12.09.24 22:58, Sami Tolvanen wrote:
> Hi Benno,
>
> On Thu, Sep 12, 2024 at 11:08 AM Benno Lossin wrote:
>>
>> On 12.09.24 18:06, Sami Tolvanen wrote:
>>>
>>> I thought about this a bit and I wonder if we need a separate
>>> mechanism for that, or is it sufficient to just #define any addition
Hi Benno,
On Thu, Sep 12, 2024 at 11:08 AM Benno Lossin wrote:
>
> On 12.09.24 18:06, Sami Tolvanen wrote:
> >
> > I thought about this a bit and I wonder if we need a separate
> > mechanism for that, or is it sufficient to just #define any additional
> > hidden values you want to add instead of
On 12.09.24 18:06, Sami Tolvanen wrote:
> On Wed, Sep 11, 2024 at 4:43 AM Petr Pavlu wrote:
>>
>> On 8/31/24 02:05, Sami Tolvanen wrote:
>>> On Fri, Aug 30, 2024 at 9:34 AM Miroslav Benes wrote:
yes, this is one of the approaches we use in SLES. We add kabi paddings
to some structu
On Wed, Sep 11, 2024 at 4:43 AM Petr Pavlu wrote:
>
> On 8/31/24 02:05, Sami Tolvanen wrote:
> > On Fri, Aug 30, 2024 at 9:34 AM Miroslav Benes wrote:
> >>
> >> yes, this is one of the approaches we use in SLES. We add kabi paddings
> >> to some structures in advance (see [1] as a random example)
On 8/31/24 02:05, Sami Tolvanen wrote:
> On Fri, Aug 30, 2024 at 9:34 AM Miroslav Benes wrote:
>>
>> yes, this is one of the approaches we use in SLES. We add kabi paddings
>> to some structures in advance (see [1] as a random example) and then use
>> it later if needed.
>>
>> It is not the only a
Hi Miroslav,
On Fri, Aug 30, 2024 at 9:34 AM Miroslav Benes wrote:
>
> yes, this is one of the approaches we use in SLES. We add kabi paddings
> to some structures in advance (see [1] as a random example) and then use
> it later if needed.
>
> It is not the only approach. Much more often we do no
Hi,
On Thu, 15 Aug 2024, Sami Tolvanen wrote:
> Distributions that want to maintain a stable kABI need the ability to
> add reserved fields to kernel data structures that they anticipate
> will be modified during the ABI support timeframe, either by LTS
> updates or backports.
>
> With genksyms,
On 23.08.24 21:17, Sami Tolvanen wrote:
> On Thu, Aug 22, 2024 at 11:53 PM Greg Kroah-Hartman
> wrote:
>>
>> On Thu, Aug 22, 2024 at 12:00:15PM +, Benno Lossin wrote:
Here's one example in the android tree where 4 64bit fields are reserved
for future abi changes:
https
On 23.08.24 01:53, Greg Kroah-Hartman wrote:
> On Thu, Aug 22, 2024 at 12:00:15PM +, Benno Lossin wrote:
>>> Here's one example in the android tree where 4 64bit fields are reserved
>>> for future abi changes:
>>>
>>> https://android.googlesource.com/kernel/common/+/refs/heads/android12-5.
On Thu, Aug 22, 2024 at 11:53 PM Greg Kroah-Hartman
wrote:
>
> On Thu, Aug 22, 2024 at 12:00:15PM +, Benno Lossin wrote:
> > > Here's one example in the android tree where 4 64bit fields are reserved
> > > for future abi changes:
> > >
> > > https://android.googlesource.com/kernel/common/
On Thu, Aug 22, 2024 at 12:00:15PM +, Benno Lossin wrote:
> > Here's one example in the android tree where 4 64bit fields are reserved
> > for future abi changes:
> >
> > https://android.googlesource.com/kernel/common/+/refs/heads/android12-5.10/include/linux/fs.h#421
> >
> > And here's a
On 22.08.24 09:29, Greg Kroah-Hartman wrote:
> On Thu, Aug 22, 2024 at 05:55:32AM +, Benno Lossin wrote:
>> On 22.08.24 01:29, Greg Kroah-Hartman wrote:
>>> On Wed, Aug 21, 2024 at 11:31:25AM +, Benno Lossin wrote:
On 20.08.24 22:03, Matthew Maurer wrote:
>>> The way `KAbiReserved`
On Thu, Aug 22, 2024 at 05:55:32AM +, Benno Lossin wrote:
> On 22.08.24 01:29, Greg Kroah-Hartman wrote:
> > On Wed, Aug 21, 2024 at 11:31:25AM +, Benno Lossin wrote:
> >> On 20.08.24 22:03, Matthew Maurer wrote:
> > The way `KAbiReserved` is implemented is via a `union` (maybe a bit
>
On 22.08.24 01:29, Greg Kroah-Hartman wrote:
> On Wed, Aug 21, 2024 at 11:31:25AM +, Benno Lossin wrote:
>> On 20.08.24 22:03, Matthew Maurer wrote:
> The way `KAbiReserved` is implemented is via a `union` (maybe a bit
> ironic, considering what I said in my other replies, but in this c
On Wed, Aug 21, 2024 at 11:31:25AM +, Benno Lossin wrote:
> On 20.08.24 22:03, Matthew Maurer wrote:
> >>> The way `KAbiReserved` is implemented is via a `union` (maybe a bit
> >>> ironic, considering what I said in my other replies, but in this case,
> >>> we would provide a safe abstraction o
On Wed, Aug 21, 2024 at 4:31 AM Benno Lossin wrote:
>
> On 20.08.24 22:03, Matthew Maurer wrote:
> >>> The way `KAbiReserved` is implemented is via a `union` (maybe a bit
> >>> ironic, considering what I said in my other replies, but in this case,
> >>> we would provide a safe abstraction over thi
On 20.08.24 22:03, Matthew Maurer wrote:
>>> The way `KAbiReserved` is implemented is via a `union` (maybe a bit
>>> ironic, considering what I said in my other replies, but in this case,
>>> we would provide a safe abstraction over this `union`, thus avoiding
>>> exposing users of this type to `un
> > The way `KAbiReserved` is implemented is via a `union` (maybe a bit
> > ironic, considering what I said in my other replies, but in this case,
> > we would provide a safe abstraction over this `union`, thus avoiding
> > exposing users of this type to `unsafe`):
> >
> > #[repr(C)]
> > pu
On Mon, Aug 19, 2024 at 10:17 PM Benno Lossin wrote:
>
> On 19.08.24 21:38, Sami Tolvanen wrote:
> >
> > This definitely looks cleaner than unions in Rust, but how would this
> > scheme be visible in DWARF? You might also need to expand the annotation
> > to allow replacing one reserved field with
On 19.08.24 21:38, Sami Tolvanen wrote:
> Hi Benno,
>
> On Sat, Aug 17, 2024 at 01:19:55PM +, Benno Lossin wrote:
>>
>> For this use-case (the one in the patch), I don't really know if we want
>> to copy the approach from C. Do we even support exporting kABI from
>> Rust? If yes, then we I wou
On 19.08.24 20:25, Greg Kroah-Hartman wrote:
> On Sat, Aug 17, 2024 at 01:19:55PM +, Benno Lossin wrote:
>> On 17.08.24 09:41, Greg Kroah-Hartman wrote:
>>> On Fri, Aug 16, 2024 at 08:50:53AM -0700, Sami Tolvanen wrote:
On Fri, Aug 16, 2024 at 12:20 AM Greg Kroah-Hartman
wrote:
>
Hi Benno,
On Sat, Aug 17, 2024 at 01:19:55PM +, Benno Lossin wrote:
>
> For this use-case (the one in the patch), I don't really know if we want
> to copy the approach from C. Do we even support exporting kABI from
> Rust? If yes, then we I would recommend we tag it in the source code
> inste
On Sat, Aug 17, 2024 at 01:19:55PM +, Benno Lossin wrote:
> On 17.08.24 09:41, Greg Kroah-Hartman wrote:
> > On Fri, Aug 16, 2024 at 08:50:53AM -0700, Sami Tolvanen wrote:
> >> On Fri, Aug 16, 2024 at 12:20 AM Greg Kroah-Hartman
> >> wrote:
> >>> On Thu, Aug 15, 2024 at 05:39:20PM +, Sami
On 17.08.24 09:41, Greg Kroah-Hartman wrote:
> On Fri, Aug 16, 2024 at 08:50:53AM -0700, Sami Tolvanen wrote:
>> On Fri, Aug 16, 2024 at 12:20 AM Greg Kroah-Hartman
>> wrote:
>>> On Thu, Aug 15, 2024 at 05:39:20PM +, Sami Tolvanen wrote:
>>> Especially as I have no idea how you are going to do
On Fri, Aug 16, 2024 at 08:50:53AM -0700, Sami Tolvanen wrote:
> Hi Greg,
>
> On Fri, Aug 16, 2024 at 12:20 AM Greg Kroah-Hartman
> wrote:
> >
> > On Thu, Aug 15, 2024 at 05:39:20PM +, Sami Tolvanen wrote:
> > > Distributions that want to maintain a stable kABI need the ability to
> > > add r
Hi Greg,
On Fri, Aug 16, 2024 at 12:20 AM Greg Kroah-Hartman
wrote:
>
> On Thu, Aug 15, 2024 at 05:39:20PM +, Sami Tolvanen wrote:
> > Distributions that want to maintain a stable kABI need the ability to
> > add reserved fields to kernel data structures that they anticipate
> > will be modif
On Thu, Aug 15, 2024 at 05:39:20PM +, Sami Tolvanen wrote:
> Distributions that want to maintain a stable kABI need the ability to
> add reserved fields to kernel data structures that they anticipate
> will be modified during the ABI support timeframe, either by LTS
> updates or backports.
>
>
Distributions that want to maintain a stable kABI need the ability to
add reserved fields to kernel data structures that they anticipate
will be modified during the ABI support timeframe, either by LTS
updates or backports.
With genksyms, developers would typically hide changes to the reserved
fie
30 matches
Mail list logo
