RE: [PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi descriptor check

2017-09-26 Thread Mario.Limonciello
ect: Re: [PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi > descriptor check > > On Tuesday 26 September 2017 20:50:12 Mario Limonciello wrote: > > + if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0) > > Should not be this memcmp? IIRC we want to c

Re: [PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi descriptor check

2017-09-26 Thread Pali Rohár
On Tuesday 26 September 2017 20:50:12 Mario Limonciello wrote: > + if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0) Should not be this memcmp? IIRC we want to compare that buffer is equal to some bytes, right? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a di

[PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi descriptor check

2017-09-26 Thread Mario Limonciello
Some cases the wrong type was used for errors and checks can be done more cleanly. Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-wmi-smbios.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/dell-wmi-smbios.c b/drivers/platform