RE: [PATCH v2 11/33] x86/intel_rdt: Hot cpu support for Cache Allocation

2016-09-13 Thread Luck, Tony
> Just for my info, why do we need not update MSRs when a cpu goes offline? The CBM (cache bitmask) MSRs are shared by all the cpus that use that same cache. So they mustn't be updated when some of the CPUs go offline, because the remaining ones are still using them. I suppose you could do somet

Re: [PATCH v2 11/33] x86/intel_rdt: Hot cpu support for Cache Allocation

2016-09-13 Thread Nilay Vaish
On 8 September 2016 at 04:57, Fenghua Yu wrote: > diff --git a/arch/x86/kernel/cpu/intel_rdt.c b/arch/x86/kernel/cpu/intel_rdt.c > index 9f30492..4537658 100644 > --- a/arch/x86/kernel/cpu/intel_rdt.c > +++ b/arch/x86/kernel/cpu/intel_rdt.c > @@ -141,6 +145,80 @@ static inline bool rdt_cpumask_upd

Re: [PATCH v2 11/33] x86/intel_rdt: Hot cpu support for Cache Allocation

2016-09-08 Thread Thomas Gleixner
On Thu, 8 Sep 2016, Fenghua Yu wrote: > +/* > + * cbm_update_msrs() - Updates all the existing IA32_L3_MASK_n MSRs > + * which are one per CLOSid on the current package. > + */ > +static void cbm_update_msrs(void *dummy) > +{ > + int maxid = boot_cpu_data.x86_cache_max_closid; > + struct rd

[PATCH v2 11/33] x86/intel_rdt: Hot cpu support for Cache Allocation

2016-09-08 Thread Fenghua Yu
From: Vikas Shivappa This patch adds hot plug cpu support for Intel Cache allocation. Support includes updating the cache bitmask MSRs IA32_L3_QOS_n when a new CPU package comes online or goes offline. The IA32_L3_QOS_n MSRs are one per Class of service on each CPU package. The new package's MSRs