Re: [PATCH v2 11/13] NTB: convert to dmaengine_unmap_data

2013-10-22 Thread Jon Mason
On Tue, Oct 22, 2013 at 06:05:31PM -0700, Dan Williams wrote: > On Tue, Oct 22, 2013 at 4:12 PM, Jon Mason wrote: > > On Tue, Oct 22, 2013 at 02:29:36PM -0700, Dan Williams wrote: > >> On Fri, Oct 18, 2013 at 6:06 PM, Jon Mason wrote: > >> > On Fri, Oct 18, 2013 at 07:35:31PM +0200, Bartlomiej Zo

Re: [PATCH v2 11/13] NTB: convert to dmaengine_unmap_data

2013-10-22 Thread Dan Williams
On Tue, Oct 22, 2013 at 4:12 PM, Jon Mason wrote: > On Tue, Oct 22, 2013 at 02:29:36PM -0700, Dan Williams wrote: >> On Fri, Oct 18, 2013 at 6:06 PM, Jon Mason wrote: >> > On Fri, Oct 18, 2013 at 07:35:31PM +0200, Bartlomiej Zolnierkiewicz wrote: >> >> Use the generic unmap object to unmap dma bu

Re: [PATCH v2 11/13] NTB: convert to dmaengine_unmap_data

2013-10-22 Thread Jon Mason
On Tue, Oct 22, 2013 at 02:29:36PM -0700, Dan Williams wrote: > On Fri, Oct 18, 2013 at 6:06 PM, Jon Mason wrote: > > On Fri, Oct 18, 2013 at 07:35:31PM +0200, Bartlomiej Zolnierkiewicz wrote: > >> Use the generic unmap object to unmap dma buffers. > >> > >> As NTB can be compiled without DMA_ENGI

Re: [PATCH v2 11/13] NTB: convert to dmaengine_unmap_data

2013-10-22 Thread Dan Williams
On Fri, Oct 18, 2013 at 6:06 PM, Jon Mason wrote: > On Fri, Oct 18, 2013 at 07:35:31PM +0200, Bartlomiej Zolnierkiewicz wrote: >> Use the generic unmap object to unmap dma buffers. >> >> As NTB can be compiled without DMA_ENGINE support add > > Seems like the stubs should be added outside of this

[PATCH v2 11/13] NTB: convert to dmaengine_unmap_data

2013-10-22 Thread Dan Williams
From: Bartlomiej Zolnierkiewicz Use the generic unmap object to unmap dma buffers. As NTB can be compiled without DMA_ENGINE support add stub functions to for dma_set_unmap(), dmaengine_get_unmap_data() and dmaengine_unmap_put(). Cc: Dan Williams Cc: Vinod Koul Cc: Tomasz Figa Cc: Dave Jian

Re: [PATCH v2 11/13] NTB: convert to dmaengine_unmap_data

2013-10-18 Thread Jon Mason
On Fri, Oct 18, 2013 at 07:35:31PM +0200, Bartlomiej Zolnierkiewicz wrote: > Use the generic unmap object to unmap dma buffers. > > As NTB can be compiled without DMA_ENGINE support add Seems like the stubs should be added outside of this patch. Also, the comment implies that NTB could not be co

[PATCH v2 11/13] NTB: convert to dmaengine_unmap_data

2013-10-18 Thread Bartlomiej Zolnierkiewicz
Use the generic unmap object to unmap dma buffers. As NTB can be compiled without DMA_ENGINE support add stub functions to for dma_set_unmap(), dmaengine_get_unmap_data() and dmaengine_unmap_put(). Cc: Dan Williams Cc: Vinod Koul Cc: Tomasz Figa Cc: Dave Jiang Cc: Jon Mason Signed-off-by: B