Re: [PATCH v2 11/13] KVM: x86: add KVM_CAP_X2APIC_API

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 12:33, Yang Zhang wrote: > On 2016/7/11 17:17, Paolo Bonzini wrote: >> On 11/07/2016 10:56, Yang Zhang wrote: >>> On 2016/7/11 15:44, Paolo Bonzini wrote: On 11/07/2016 08:06, Yang Zhang wrote: If interrupt remapping is on, KVM_CAP_X2APIC_API is needed even with 8 VCP

Re: [PATCH v2 11/13] KVM: x86: add KVM_CAP_X2APIC_API

2016-07-11 Thread Yang Zhang
On 2016/7/11 17:17, Paolo Bonzini wrote: On 11/07/2016 10:56, Yang Zhang wrote: On 2016/7/11 15:44, Paolo Bonzini wrote: On 11/07/2016 08:06, Yang Zhang wrote: Changes to MSI addresses follow the format used by interrupt remapping unit. The upper address word, that used to be 0, contains u

Re: [PATCH v2 11/13] KVM: x86: add KVM_CAP_X2APIC_API

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 10:56, Yang Zhang wrote: > On 2016/7/11 15:44, Paolo Bonzini wrote: >> >> >> On 11/07/2016 08:06, Yang Zhang wrote: Changes to MSI addresses follow the format used by interrupt remapping unit. The upper address word, that used to be 0, contains upper 24 bits of t

Re: [PATCH v2 11/13] KVM: x86: add KVM_CAP_X2APIC_API

2016-07-11 Thread Yang Zhang
On 2016/7/11 15:44, Paolo Bonzini wrote: On 11/07/2016 08:06, Yang Zhang wrote: Changes to MSI addresses follow the format used by interrupt remapping unit. The upper address word, that used to be 0, contains upper 24 bits of the LAPIC address in its upper 24 bits. Lower 8 bits are reserved a

Re: [PATCH v2 11/13] KVM: x86: add KVM_CAP_X2APIC_API

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 08:06, Yang Zhang wrote: >> Changes to MSI addresses follow the format used by interrupt remapping >> unit. >> The upper address word, that used to be 0, contains upper 24 bits of >> the LAPIC >> address in its upper 24 bits. Lower 8 bits are reserved as 0. >> Using the upper addre

Re: [PATCH v2 11/13] KVM: x86: add KVM_CAP_X2APIC_API

2016-07-10 Thread Yang Zhang
On 2016/7/8 1:15, Radim Krčmář wrote: KVM_CAP_X2APIC_API can be enabled to extend APIC ID in get/set ioctl and MSI addresses to 32 bits. Both are needed to support x2APIC. The capability has to be toggleable and disabled by default, because get/set ioctl shifted and truncated APIC ID to 8 bits

[PATCH v2 11/13] KVM: x86: add KVM_CAP_X2APIC_API

2016-07-07 Thread Radim Krčmář
KVM_CAP_X2APIC_API can be enabled to extend APIC ID in get/set ioctl and MSI addresses to 32 bits. Both are needed to support x2APIC. The capability has to be toggleable and disabled by default, because get/set ioctl shifted and truncated APIC ID to 8 bits by using a non-standard protocol inspire