Re: [PATCH v2 10/10] perf tools: Move TUI-specific fields out of map_symbol

2015-05-05 Thread Arnaldo Carvalho de Melo
Em Tue, May 05, 2015 at 11:22:31AM -0300, Arnaldo Carvalho de Melo escreveu: > We will need a v3, this fixes the 'E'xpand segfault, but not the first > problem reported, again, this time step by step: > Samples: 1K of event 'cycles', Event count (approx.): 1597853394 > Children Self Comma

Re: [PATCH v2 10/10] perf tools: Move TUI-specific fields out of map_symbol

2015-05-05 Thread Arnaldo Carvalho de Melo
Em Tue, May 05, 2015 at 10:18:10AM +0900, Namhyung Kim escreveu: > The has_children and unfolded fields don't belong to struct map_symbol > since they're used by TUI only. Move those fields out of map_symbol > since the struct is also used by other places. > This will also help to compact the si

Re: [PATCH v2 10/10] perf tools: Move TUI-specific fields out of map_symbol

2015-05-05 Thread Namhyung Kim
On Tue, May 05, 2015 at 11:26:26AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, May 05, 2015 at 11:22:31AM -0300, Arnaldo Carvalho de Melo escreveu: > > We will need a v3, this fixes the 'E'xpand segfault, but not the first > > problem reported, again, this time step by step: > > > Samples: 1

[PATCH v2 10/10] perf tools: Move TUI-specific fields out of map_symbol

2015-05-04 Thread Namhyung Kim
The has_children and unfolded fields don't belong to struct map_symbol since they're used by TUI only. Move those fields out of map_symbol since the struct is also used by other places. This will also help to compact the sizeof struct hist_entry. Signed-off-by: Namhyung Kim Acked-by: Jiri Olsa