Re: [PATCH v2 1/9] mtd:fsl-quadspi:use the property fields of SPI-NOR

2016-07-21 Thread Han Xu
On Thu, Jul 21, 2016 at 12:09 PM, Brian Norris wrote: > On Thu, Jul 21, 2016 at 05:58:48AM +, Yunhui Cui wrote: >> Could you please help to review this patch set. >> This patch set is very importmant for fsl-quadspi driver. > > I didn't want this to be my only comment, but since you're pinging

Re: [PATCH v2 1/9] mtd:fsl-quadspi:use the property fields of SPI-NOR

2016-07-21 Thread Brian Norris
On Thu, Jul 21, 2016 at 05:58:48AM +, Yunhui Cui wrote: > Could you please help to review this patch set. > This patch set is very importmant for fsl-quadspi driver. I didn't want this to be my only comment, but since you're pinging again... Your patchset doesn't build on the latest. You nee

RE: [PATCH v2 1/9] mtd:fsl-quadspi:use the property fields of SPI-NOR

2016-07-21 Thread Yunhui Cui
dead.org; > > linux- arm-ker...@lists.infradead.org; Yao Yuan; Yunhui Cui > > Subject: [PATCH v2 1/9] mtd:fsl-quadspi:use the property fields of > > SPI- NOR > > > > We can get the read/write/erase opcode from the spi nor framework > > directly. This patch uses th

RE: [PATCH v2 1/9] mtd:fsl-quadspi:use the property fields of SPI-NOR

2016-06-29 Thread Yunhui Cui
escale.com > Cc: linux-kernel@vger.kernel.org; linux-...@lists.infradead.org; linux- > arm-ker...@lists.infradead.org; Yao Yuan; Yunhui Cui > Subject: [PATCH v2 1/9] mtd:fsl-quadspi:use the property fields of SPI- > NOR > > We can get the read/write/erase opcode from the spi nor fram

[PATCH v2 1/9] mtd:fsl-quadspi:use the property fields of SPI-NOR

2016-04-21 Thread Yunhui Cui
We can get the read/write/erase opcode from the spi nor framework directly. This patch uses the information stored in the SPI-NOR to remove the hardcode in the fsl_qspi_init_lut(). Signed-off-by: Yunhui Cui Signed-off-by: Yunhui Cui --- drivers/mtd/spi-nor/fsl-quadspi.c | 40 ---