Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

2015-12-08 Thread Arnd Bergmann
On Tuesday 08 December 2015 17:45:25 xuejiancheng wrote: > On 2015/12/7 17:36, Arnd Bergmann wrote: > > On Monday 07 December 2015 16:01:03 xuejiancheng wrote: > >> On 2015/12/4 18:56, Arnd Bergmann wrote: > >>> On Friday 04 December 2015 11:21:28 xuejiancheng wrote: > Hi Arnd, > > O

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

2015-12-08 Thread xuejiancheng
On 2015/12/7 17:36, Arnd Bergmann wrote: > On Monday 07 December 2015 16:01:03 xuejiancheng wrote: >> On 2015/12/4 18:56, Arnd Bergmann wrote: >>> On Friday 04 December 2015 11:21:28 xuejiancheng wrote: Hi Arnd, On 2015/12/3 17:44, Arnd Bergmann wrote: > On Thursday 03 December

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

2015-12-07 Thread xuejiancheng
On 2015/12/7 17:36, Arnd Bergmann wrote: > On Monday 07 December 2015 16:01:03 xuejiancheng wrote: >> On 2015/12/4 18:56, Arnd Bergmann wrote: >>> On Friday 04 December 2015 11:21:28 xuejiancheng wrote: Hi Arnd, On 2015/12/3 17:44, Arnd Bergmann wrote: > On Thursday 03 December

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

2015-12-07 Thread Arnd Bergmann
On Monday 07 December 2015 16:01:03 xuejiancheng wrote: > On 2015/12/4 18:56, Arnd Bergmann wrote: > > On Friday 04 December 2015 11:21:28 xuejiancheng wrote: > >> Hi Arnd, > >> > >> On 2015/12/3 17:44, Arnd Bergmann wrote: > >>> On Thursday 03 December 2015 10:39:24 Jiancheng Xue wrote: > +#i

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

2015-12-07 Thread xuejiancheng
On 2015/12/4 18:56, Arnd Bergmann wrote: > On Friday 04 December 2015 11:21:28 xuejiancheng wrote: >> Hi Arnd, >> >> On 2015/12/3 17:44, Arnd Bergmann wrote: >>> On Thursday 03 December 2015 10:39:24 Jiancheng Xue wrote: +#ifndef __DTS_HI3519_CLOCK_H +#define __DTS_HI3519_CLOCK_H >>> >>>

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

2015-12-04 Thread Arnd Bergmann
On Friday 04 December 2015 11:21:28 xuejiancheng wrote: > Hi Arnd, > > On 2015/12/3 17:44, Arnd Bergmann wrote: > > On Thursday 03 December 2015 10:39:24 Jiancheng Xue wrote: > >> +#ifndef __DTS_HI3519_CLOCK_H > >> +#define __DTS_HI3519_CLOCK_H > > > > Please try to avoid adding headers like this

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

2015-12-03 Thread xuejiancheng
Hi Arnd, On 2015/12/3 17:44, Arnd Bergmann wrote: > On Thursday 03 December 2015 10:39:24 Jiancheng Xue wrote: >> +#ifndef __DTS_HI3519_CLOCK_H >> +#define __DTS_HI3519_CLOCK_H > > Please try to avoid adding headers like this if you can at all. > > I might ask you to merge the header file in one

Re: [PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

2015-12-03 Thread Arnd Bergmann
On Thursday 03 December 2015 10:39:24 Jiancheng Xue wrote: > +#ifndef __DTS_HI3519_CLOCK_H > +#define __DTS_HI3519_CLOCK_H Please try to avoid adding headers like this if you can at all. I might ask you to merge the header file in one merge window otherwise and submit the platform code one kernel

[PATCH v2 1/9] clk: hi3519: add dt-binding document and header file

2015-12-02 Thread Jiancheng Xue
add dt-binding document and header file for hi3519 clock Signed-off-by: Jiancheng Xue --- .../devicetree/bindings/clock/hi3519-crg.txt | 46 +++ include/dt-bindings/clock/hi3519-clock.h | 51 ++ 2 files changed, 97 insertions(+) create mode 10