Re: [PATCH v2 1/6] virtio_balloon: transitional interface

2015-04-01 Thread Michael S. Tsirkin
On Wed, Apr 01, 2015 at 12:57:48PM +0200, Cornelia Huck wrote: > On Wed, 1 Apr 2015 12:28:30 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Apr 01, 2015 at 12:22:44PM +0200, Cornelia Huck wrote: > > > On Wed, 1 Apr 2015 11:43:46 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Wed, A

Re: [PATCH v2 1/6] virtio_balloon: transitional interface

2015-04-01 Thread Cornelia Huck
On Wed, 1 Apr 2015 12:28:30 +0200 "Michael S. Tsirkin" wrote: > On Wed, Apr 01, 2015 at 12:22:44PM +0200, Cornelia Huck wrote: > > On Wed, 1 Apr 2015 11:43:46 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Apr 01, 2015 at 07:53:14PM +1030, Rusty Russell wrote: > > > > "Michael S. Tsirk

Re: [PATCH v2 1/6] virtio_balloon: transitional interface

2015-04-01 Thread Michael S. Tsirkin
On Wed, Apr 01, 2015 at 12:22:44PM +0200, Cornelia Huck wrote: > On Wed, 1 Apr 2015 11:43:46 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Apr 01, 2015 at 07:53:14PM +1030, Rusty Russell wrote: > > > "Michael S. Tsirkin" writes: > > > > On Wed, Apr 01, 2015 at 02:17:23PM +1030, Rusty Russell

Re: [PATCH v2 1/6] virtio_balloon: transitional interface

2015-04-01 Thread Cornelia Huck
On Wed, 1 Apr 2015 11:43:46 +0200 "Michael S. Tsirkin" wrote: > On Wed, Apr 01, 2015 at 07:53:14PM +1030, Rusty Russell wrote: > > "Michael S. Tsirkin" writes: > > > On Wed, Apr 01, 2015 at 02:17:23PM +1030, Rusty Russell wrote: > > >> I would leave the device *exactly* as is, ugly structure pac

Re: [PATCH v2 1/6] virtio_balloon: transitional interface

2015-04-01 Thread Michael S. Tsirkin
On Wed, Apr 01, 2015 at 07:53:14PM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > On Wed, Apr 01, 2015 at 02:17:23PM +1030, Rusty Russell wrote: > >> I would leave the device *exactly* as is, ugly structure packing and > >> all. > > > > But why? It's going to be used for years, mi

Re: [PATCH v2 1/6] virtio_balloon: transitional interface

2015-04-01 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Wed, Apr 01, 2015 at 02:17:23PM +1030, Rusty Russell wrote: >> I would leave the device *exactly* as is, ugly structure packing and >> all. > > But why? It's going to be used for years, might as well make it clean? Because the only spec which currently exists sa

Re: [PATCH v2 1/6] virtio_balloon: transitional interface

2015-04-01 Thread Michael S. Tsirkin
On Wed, Apr 01, 2015 at 02:17:23PM +1030, Rusty Russell wrote: > I would leave the device *exactly* as is, ugly structure packing and > all. But why? It's going to be used for years, might as well make it clean? -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH v2 1/6] virtio_balloon: transitional interface

2015-03-31 Thread Rusty Russell
"Michael S. Tsirkin" writes: > Virtio 1.0 doesn't include a modern balloon device. > But it's not a big change to support a transitional > balloon device: this has the advantage of supporting > existing drivers, transparently. You decided to fix the packed struct... > diff --git a/drivers/virtio

[PATCH v2 1/6] virtio_balloon: transitional interface

2015-03-31 Thread Michael S. Tsirkin
Virtio 1.0 doesn't include a modern balloon device. But it's not a big change to support a transitional balloon device: this has the advantage of supporting existing drivers, transparently. Signed-off-by: Michael S. Tsirkin --- include/uapi/linux/virtio_balloon.h | 11 +-- drivers/virtio