Re: [PATCH v2 1/5] pidfd: verify task is alive when printing fdinfo

2019-10-17 Thread Oleg Nesterov
On 10/16, Christian Brauner wrote: > > On Wed, Oct 16, 2019 at 06:24:09PM +0200, Oleg Nesterov wrote: > > > > And why task_ if it accepts pid+pid_type? May be pid_has_task() or > > something like this... > > Given what I said above that might be a decent name. > > > > > OK, since I can't suggest a

Re: [PATCH v2 1/5] pidfd: verify task is alive when printing fdinfo

2019-10-16 Thread Christian Brauner
On Wed, Oct 16, 2019 at 06:24:09PM +0200, Oleg Nesterov wrote: > On 10/16, Christian Brauner wrote: > > > > +static inline bool task_alive(struct pid *pid, enum pid_type type) > > +{ > > + return !hlist_empty(&pid->tasks[type]); > > +} > > So you decided to add a helper ;) OK, but note that its

Re: [PATCH v2 1/5] pidfd: verify task is alive when printing fdinfo

2019-10-16 Thread Oleg Nesterov
On 10/16, Christian Brauner wrote: > > +static inline bool task_alive(struct pid *pid, enum pid_type type) > +{ > + return !hlist_empty(&pid->tasks[type]); > +} So you decided to add a helper ;) OK, but note that its name is very confusing and misleading. Even more than pid_alive() we already

[PATCH v2 1/5] pidfd: verify task is alive when printing fdinfo

2019-10-16 Thread Christian Brauner
Currently, when a task is dead we still print the pid it used to use in the fdinfo files of its pidfds. This doesn't make much sense since the pid may have already been reused. So verify that the task is still alive by introducing the task_alive() helper which will be used by other callers in follo