Re: Re: [PATCH v2 1/5] perf probe: Split add_perf_probe_events()

2015-09-11 Thread Namhyung Kim
On Thu, Sep 10, 2015 at 08:10:16AM +, 平松雅巳 / HIRAMATU，MASAMI wrote: > Hi Namhyung, > > From: Namhyung Kim [mailto:namhy...@gmail.com] On Behalf Of Namhyung Kim > > > >Hi Masami, > > > >On Thu, Sep 10, 2015 at 05:00:07AM +, 平松雅巳 / HIRAMATU，MASAMI wrote: > >> >From: Namhyung Kim [mailto:namh

RE: Re: [PATCH v2 1/5] perf probe: Split add_perf_probe_events()

2015-09-10 Thread 平松雅巳 / HIRAMATU，MASAMI
Hi Namhyung, From: Namhyung Kim [mailto:namhy...@gmail.com] On Behalf Of Namhyung Kim > >Hi Masami, > >On Thu, Sep 10, 2015 at 05:00:07AM +, 平松雅巳 / HIRAMATU，MASAMI wrote: >> >From: Namhyung Kim [mailto:namhy...@gmail.com] On Behalf Of Namhyung Kim >> >The del_perf_probe_events() uses strfilter

Re: Re: [PATCH v2 1/5] perf probe: Split add_perf_probe_events()

2015-09-09 Thread Namhyung Kim
Hi Masami, On Thu, Sep 10, 2015 at 05:00:07AM +, 平松雅巳 / HIRAMATU，MASAMI wrote: > >From: Namhyung Kim [mailto:namhy...@gmail.com] On Behalf Of Namhyung Kim > >The del_perf_probe_events() uses strfilter, but I think it can be > >problematic if other instances or users are using similar events at

RE: Re: [PATCH v2 1/5] perf probe: Split add_perf_probe_events()

2015-09-09 Thread 平松雅巳 / HIRAMATU，MASAMI
>From: Namhyung Kim [mailto:namhy...@gmail.com] On Behalf Of Namhyung Kim > >On Sun, Sep 06, 2015 at 03:47:37PM +0800, Wangnan (F) wrote: >> Hi Namhyung, > >Hi, > >> >> Thanks for this patchset. >> >> Could you plase have a look at patch 5/27 and 6/27 in my newest pull >> request? >> These 2 patche

Re: [PATCH v2 1/5] perf probe: Split add_perf_probe_events()

2015-09-09 Thread Namhyung Kim
On Sun, Sep 06, 2015 at 03:47:37PM +0800, Wangnan (F) wrote: > Hi Namhyung, Hi, > > Thanks for this patchset. > > Could you plase have a look at patch 5/27 and 6/27 in my newest pull > request? > These 2 patches utilize new probing API to create probe point and collect > probe_trace_events. I'm

Re: [PATCH v2 1/5] perf probe: Split add_perf_probe_events()

2015-09-07 Thread Namhyung Kim
On Sun, Sep 06, 2015 at 03:47:37PM +0800, Wangnan (F) wrote: > Hi Namhyung, Hi, I'm off until Wednesday. I'll be able to take a look at it on Thursday. Thanks, Namhyung > > Thanks for this patchset. > > Could you plase have a look at patch 5/27 and 6/27 in my newest pull > request? > These

Re: [PATCH v2 1/5] perf probe: Split add_perf_probe_events()

2015-09-06 Thread Wangnan (F)
Hi Namhyung, Thanks for this patchset. Could you plase have a look at patch 5/27 and 6/27 in my newest pull request? These 2 patches utilize new probing API to create probe point and collect probe_trace_events. I'm not very sure I fully understand your design principle, especially the cleanup

[PATCH v2 1/5] perf probe: Split add_perf_probe_events()

2015-09-04 Thread Namhyung Kim
The add_perf_probe_events() does 3 things: 1. convert all perf events to trace events 2. add all trace events to kernel 3. cleanup all trace events But sometimes we need to do something with the trace events. So split the funtion into three, so that it can access intermediate trace events via