Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-07-23 Thread Dong Aisheng
On Thu, Jul 23, 2015 at 05:11:35PM -0700, Michael Turquette wrote: > Quoting Dong Aisheng (2015-07-22 07:08:10) > > Ping... > > > > On Wed, Jul 15, 2015 at 08:29:56PM +0800, Dong Aisheng wrote: > > > On Wed, Jul 15, 2015 at 08:25:24PM +0800, Dong Aisheng wrote: > > > > Hi Mike, > > > > > > > > On

Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-07-22 Thread Dong Aisheng
Ping... On Wed, Jul 15, 2015 at 08:29:56PM +0800, Dong Aisheng wrote: > On Wed, Jul 15, 2015 at 08:25:24PM +0800, Dong Aisheng wrote: > > Hi Mike, > > > > On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > > > Quoting Dong Aisheng (2015-05-14 06:28:59) > > > > __clk_set_parent_a

Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-07-15 Thread Dong Aisheng
On Wed, Jul 15, 2015 at 08:25:24PM +0800, Dong Aisheng wrote: > Hi Mike, > > On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > > Quoting Dong Aisheng (2015-05-14 06:28:59) > > > __clk_set_parent_after() actually used the second argument then we > > > could put this duplicate log

Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-07-15 Thread Dong Aisheng
Hi Mike, On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > Quoting Dong Aisheng (2015-05-14 06:28:59) > > __clk_set_parent_after() actually used the second argument then we > > could put this duplicate logic in there and call it with a different > > order of arguments in the suc

Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-05-28 Thread Dong Aisheng
On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > Quoting Dong Aisheng (2015-05-14 06:28:59) > > __clk_set_parent_after() actually used the second argument then we > > could put this duplicate logic in there and call it with a different > > order of arguments in the success vs. e

Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-05-27 Thread Michael Turquette
Quoting Dong Aisheng (2015-05-14 06:28:59) > __clk_set_parent_after() actually used the second argument then we > could put this duplicate logic in there and call it with a different > order of arguments in the success vs. error paths in this function. > > Cc: Mike Turquette > Cc: Stephen Boyd >

[PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after

2015-05-14 Thread Dong Aisheng
__clk_set_parent_after() actually used the second argument then we could put this duplicate logic in there and call it with a different order of arguments in the success vs. error paths in this function. Cc: Mike Turquette Cc: Stephen Boyd Suggested-by: Stephen Boyd Signed-off-by: Dong Aisheng