Re: [PATCH v2 1/5] KVM: add kvm_has_request wrapper

2015-08-14 Thread Radim Krčmář
2015-08-13 12:03+0200, Christian Borntraeger: > Am 13.08.2015 um 11:29 schrieb Paolo Bonzini: >> On 13/08/2015 11:11, Radim Krčmář wrote: > for the new interface. maybe we can rename kvm_check_request in a > separate patch somewhen. >>> I wonder why haven't we copied the naming convention

Re: [PATCH v2 1/5] KVM: add kvm_has_request wrapper

2015-08-13 Thread Christian Borntraeger
Am 13.08.2015 um 11:29 schrieb Paolo Bonzini: > > > On 13/08/2015 11:11, Radim Krčmář wrote: for the new interface. maybe we can rename kvm_check_request in a separate patch somewhen. >> I wonder why haven't we copied the naming convention from bit operations >> (or if programming woul

Re: [PATCH v2 1/5] KVM: add kvm_has_request wrapper

2015-08-13 Thread Paolo Bonzini
On 13/08/2015 11:11, Radim Krčmář wrote: >> > for the new interface. maybe we can rename kvm_check_request in a separate >> > patch somewhen. > I wonder why haven't we copied the naming convention from bit operations > (or if programming would be better if German was its language), > > kvm_te

Re: [PATCH v2 1/5] KVM: add kvm_has_request wrapper

2015-08-13 Thread Radim Krčmář
2015-08-12 21:57+0200, Christian Borntraeger: > kvm_check_request is now somewhat a misnomer (what is the difference between > test and check?) kvm_check_request has always been poetic; it uses two meanings of check, "examine" and "tick off", at the same time. We also want something that clears

Re: [PATCH v2 1/5] KVM: add kvm_has_request wrapper

2015-08-12 Thread Christian Borntraeger
Am 05.08.2015 um 18:32 schrieb Radim Krčmář: > We want to have requests abstracted from bit operations. > > Signed-off-by: Radim Krčmář > --- kvm_check_request is now somewhat a misnomer (what is the difference between test and check?) but still Acked-by: Christian Borntraeger for the new i

[PATCH v2 1/5] KVM: add kvm_has_request wrapper

2015-08-05 Thread Radim Krčmář
We want to have requests abstracted from bit operations. Signed-off-by: Radim Krčmář --- arch/x86/kvm/vmx.c | 2 +- include/linux/kvm_host.h | 7 ++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 217f66343dc8..17514fe7d2cb