On Tue, Nov 24, 2020 at 10:29 AM Sven Van Asbroeck wrote:
>
> My pleasure ! We are fortunate that you take the time & effort to improve
> this code.
By "this code" I meant the pca9685 driver in general. Just making sure
there's no possible misinterpretation :)
On Tue, Nov 24, 2020 at 10:19 AM Clemens Gruber
wrote:
>
> Thanks for your review!
My pleasure ! We are fortunate that you take the time & effort to improve
this code.
On Mon, Nov 23, 2020 at 12:38:26PM -0500, Sven Van Asbroeck wrote:
> Hi Clemens, some cool changes, thank you !! Constructive feedback below.
>
> On Mon, Nov 23, 2020 at 11:36 AM Clemens Gruber
> wrote:
> >
> > Changes since v1:
> > - Fixed a logic error
> > - Impoved PM runtime handling and fixe
Hi Clemens, some cool changes, thank you !! Constructive feedback below.
On Mon, Nov 23, 2020 at 11:36 AM Clemens Gruber
wrote:
>
> Changes since v1:
> - Fixed a logic error
> - Impoved PM runtime handling and fixed !CONFIG_PM
> - Write default prescale reg value if invalid in probe
> - Reuse ful
This switch to the atomic API goes hand in hand with a few fixes to
previously experienced issues:
- The duty cycle is no longer lost after disable/enable (previously the
OFF registers were cleared in disable and the user was required to
call config to restore the duty cycle settings)
- The pre
5 matches
Mail list logo