Re: [PATCH v2 1/4] pinctrl: rockchip: Set wake_enabled

2014-10-29 Thread Heiko Stübner
Am Dienstag, 21. Oktober 2014, 10:47:32 schrieb Doug Anderson: > The rockchip pinctrl driver uses irq_gc_set_wake() but doesn't setup > the .wake_enabled member. That means that we can never actually use a > pin for wakeup. When "irq_set_irq_wake()" tries to call through it > will always get a fa

Re: [PATCH v2 1/4] pinctrl: rockchip: Set wake_enabled

2014-10-23 Thread Heiko Stübner
Am Donnerstag, 23. Oktober 2014, 09:55:27 schrieb Doug Anderson: > Heiko, > > On Thu, Oct 23, 2014 at 9:43 AM, Heiko Stübner wrote: > > Am Dienstag, 21. Oktober 2014, 10:47:32 schrieb Doug Anderson: > >> The rockchip pinctrl driver uses irq_gc_set_wake() but doesn't setup > >> the .wake_enabled m

Re: [PATCH v2 1/4] pinctrl: rockchip: Set wake_enabled

2014-10-23 Thread Doug Anderson
Heiko, On Thu, Oct 23, 2014 at 9:43 AM, Heiko Stübner wrote: > Am Dienstag, 21. Oktober 2014, 10:47:32 schrieb Doug Anderson: >> The rockchip pinctrl driver uses irq_gc_set_wake() but doesn't setup >> the .wake_enabled member. That means that we can never actually use a >> pin for wakeup. When

Re: [PATCH v2 1/4] pinctrl: rockchip: Set wake_enabled

2014-10-23 Thread Heiko Stübner
Am Dienstag, 21. Oktober 2014, 10:47:32 schrieb Doug Anderson: > The rockchip pinctrl driver uses irq_gc_set_wake() but doesn't setup > the .wake_enabled member. That means that we can never actually use a > pin for wakeup. When "irq_set_irq_wake()" tries to call through it > will always get a fa

[PATCH v2 1/4] pinctrl: rockchip: Set wake_enabled

2014-10-21 Thread Doug Anderson
The rockchip pinctrl driver uses irq_gc_set_wake() but doesn't setup the .wake_enabled member. That means that we can never actually use a pin for wakeup. When "irq_set_irq_wake()" tries to call through it will always get a failure from set_irq_wake_real() and will then set wake_depth to 0. Assu