Re: [PATCH v2 1/4] mfd: add viperboard driver

2012-10-18 Thread Lars-Peter Clausen
On 10/18/2012 09:29 AM, Lars Poeschel wrote: > On Tuesday 16 October 2012 at 12:58:48, Lars-Peter Clausen wrote: >> On 10/16/2012 11:43 AM, Lars Poeschel wrote: >>> On Tuesday 16 October 2012 at 10:40:26, Lars-Peter Clausen wrote: On 10/12/2012 04:34 PM, Lars Poeschel wrote: Btw. I'm wond

Re: [PATCH v2 1/4] mfd: add viperboard driver

2012-10-18 Thread Lars Poeschel
On Tuesday 16 October 2012 at 12:58:48, Lars-Peter Clausen wrote: > On 10/16/2012 11:43 AM, Lars Poeschel wrote: > > On Tuesday 16 October 2012 at 10:40:26, Lars-Peter Clausen wrote: > >> On 10/12/2012 04:34 PM, Lars Poeschel wrote: > >> Btw. I'm wondering why is the extra platform device required?

Re: [PATCH v2 1/4] mfd: add viperboard driver

2012-10-16 Thread Lars-Peter Clausen
On 10/16/2012 11:43 AM, Lars Poeschel wrote: > On Tuesday 16 October 2012 at 10:40:26, Lars-Peter Clausen wrote: >> On 10/12/2012 04:34 PM, Lars Poeschel wrote: >>> [...] >>> +static void vprbrd_dev_release(struct device *dev) >>> +{ >>> + return; >> >> A empty release callback is usually a good

Re: [PATCH v2 1/4] mfd: add viperboard driver

2012-10-16 Thread Lars Poeschel
On Tuesday 16 October 2012 at 10:40:26, Lars-Peter Clausen wrote: > On 10/12/2012 04:34 PM, Lars Poeschel wrote: > > [...] > > +static void vprbrd_dev_release(struct device *dev) > > +{ > > + return; > > A empty release callback is usually a good indicator that something is > wrong. The release

Re: [PATCH v2 1/4] mfd: add viperboard driver

2012-10-16 Thread Lars-Peter Clausen
On 10/12/2012 04:34 PM, Lars Poeschel wrote: > [...] > +static void vprbrd_dev_release(struct device *dev) > +{ > + return; A empty release callback is usually a good indicator that something is wrong. The release callback will be called once the last reference to the device has been called, s

Re: [PATCH v2 1/4] mfd: add viperboard driver

2012-10-16 Thread Lars Poeschel
On Monday 15 October 2012 at 19:09:53, Peter Meerwald wrote: > minor nitpicking below > > > From: Lars Poeschel > > > > Add mfd driver for Nano River Technologies viperboard. > > > > Signed-off-by: Lars Poeschel > > --- > > > > drivers/mfd/Kconfig| 14 > > drivers/mfd/Make

Re: [PATCH v2 1/4] mfd: add viperboard driver

2012-10-15 Thread Peter Meerwald
minor nitpicking below > From: Lars Poeschel > > Add mfd driver for Nano River Technologies viperboard. > > Signed-off-by: Lars Poeschel > --- > drivers/mfd/Kconfig| 14 > drivers/mfd/Makefile |1 + > drivers/mfd/viperboard.c | 149 > +

[PATCH v2 1/4] mfd: add viperboard driver

2012-10-12 Thread Lars Poeschel
From: Lars Poeschel Add mfd driver for Nano River Technologies viperboard. Signed-off-by: Lars Poeschel --- drivers/mfd/Kconfig| 14 drivers/mfd/Makefile |1 + drivers/mfd/viperboard.c | 149 include/linux/mfd/vip