Re: [PATCH v2 1/3] tracing: uprobes: Re-enable $comm support for uprobe events

2019-02-07 Thread Masami Hiramatsu
On Wed, 6 Feb 2019 15:52:43 -0500 Steven Rostedt wrote: > On Fri, 18 Jan 2019 13:44:25 +0900 > Masami Hiramatsu wrote: > > > @@ -180,7 +183,12 @@ fetch_store_strlen(unsigned long addr) > > int len; > > void __user *vaddr = (void __force __user *) addr; > > > > - len = strnlen_user(v

Re: [PATCH v2 1/3] tracing: uprobes: Re-enable $comm support for uprobe events

2019-02-06 Thread Steven Rostedt
On Fri, 18 Jan 2019 13:44:25 +0900 Masami Hiramatsu wrote: > @@ -180,7 +183,12 @@ fetch_store_strlen(unsigned long addr) > int len; > void __user *vaddr = (void __force __user *) addr; > > - len = strnlen_user(vaddr, MAX_STRING_SIZE); > + if (addr == (unsigned long)current->

Re: [PATCH v2 1/3] tracing: uprobes: Re-enable $comm support for uprobe events

2019-01-23 Thread Masami Hiramatsu
On Wed, 23 Jan 2019 21:09:56 -0500 Steven Rostedt wrote: > On Thu, 24 Jan 2019 10:43:22 +0900 > Masami Hiramatsu wrote: > > > > > kernel/trace/trace_uprobe.c | 15 +-- > > > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/kernel/trace/trace_uprobe

Re: [PATCH v2 1/3] tracing: uprobes: Re-enable $comm support for uprobe events

2019-01-23 Thread Steven Rostedt
On Thu, 24 Jan 2019 10:43:22 +0900 Masami Hiramatsu wrote: > > > kernel/trace/trace_uprobe.c | 15 +-- > > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > > > index 3a1d5ab6b4ba..b07e498ccbc6 1

Re: [PATCH v2 1/3] tracing: uprobes: Re-enable $comm support for uprobe events

2019-01-23 Thread Masami Hiramatsu
On Wed, 23 Jan 2019 03:40:05 -0500 Steven Rostedt wrote: > On Fri, 18 Jan 2019 13:44:25 +0900 > Masami Hiramatsu wrote: > > > Since commit 533059281ee5 ("tracing: probeevent: Introduce new > > argument fetching code") dropped the $comm support from uprobe > > events, this re-enables it. > > >

Re: [PATCH v2 1/3] tracing: uprobes: Re-enable $comm support for uprobe events

2019-01-23 Thread Steven Rostedt
On Fri, 18 Jan 2019 13:44:25 +0900 Masami Hiramatsu wrote: > Since commit 533059281ee5 ("tracing: probeevent: Introduce new > argument fetching code") dropped the $comm support from uprobe > events, this re-enables it. > > For $comm support, uses strlcpy() instead of strncpy_from_user() > to cop

[PATCH v2 1/3] tracing: uprobes: Re-enable $comm support for uprobe events

2019-01-17 Thread Masami Hiramatsu
Since commit 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code") dropped the $comm support from uprobe events, this re-enables it. For $comm support, uses strlcpy() instead of strncpy_from_user() to copy current task's comm. Because it is in the kernel space, strncpy_from_us