Re: [PATCH v2 1/3] pppoatm: don't send frames to destroyed vcc

2012-10-30 Thread Krzysztof Mazur
On Tue, Oct 30, 2012 at 09:35:00AM +, David Woodhouse wrote: > On Mon, 2012-10-22 at 19:14 +0200, Krzysztof Mazur wrote: > > Now pppoatm_send(), like vcc_sendmsg(), checks for vcc flags that > > indicate that vcc is not ready. > > I note that vcc_sendmsg() also checks for sock->state == SS_CON

Re: [PATCH v2 1/3] pppoatm: don't send frames to destroyed vcc

2012-10-30 Thread David Woodhouse
On Mon, 2012-10-22 at 19:14 +0200, Krzysztof Mazur wrote: > Now pppoatm_send(), like vcc_sendmsg(), checks for vcc flags that > indicate that vcc is not ready. I note that vcc_sendmsg() also checks for sock->state == SS_CONNECTED. Is that check not needed here? Otherwise, looks sane enough. Acked

Re: [PATCH v2 1/3] pppoatm: don't send frames to destroyed vcc

2012-10-23 Thread David Woodhouse
On Tue, 2012-10-23 at 02:52 -0400, David Miller wrote: > > David, if you could review this series I'd really appreciate it. Will do. I glanced at it last night but need to be in the right frame of mind for thinking about ATM locking. I know I have a bottle of vodka *somewhere* around here... I s

Re: [PATCH v2 1/3] pppoatm: don't send frames to destroyed vcc

2012-10-22 Thread David Miller
David, if you could review this series I'd really appreciate it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tu

[PATCH v2 1/3] pppoatm: don't send frames to destroyed vcc

2012-10-22 Thread Krzysztof Mazur
The pppoatm_send() uses vcc->send() directly and does not check if vcc is ready for send(). This causes Oops when send() is used after vcc_destroy_socket() at least with usbatm driver: Oops: [#1] PREEMPT Pid: 0, comm: swapper Not tainted 3.6.0-krzysiek-1-gb7cd93b-dirty #60 /AK32 EIP: